Monte9 / react-native-ratings

Tap and Swipe Ratings component for React Native.
https://expo.io/@monte9/react-native-ratings
MIT License
907 stars 196 forks source link

Fix image assets import issue #146

Closed khushal87 closed 3 years ago

khushal87 commented 3 years ago

Fixes - #145

khushal87 commented 3 years ago

@sshivananda Please review this PR on priority. Many users are facing issue.

sshivananda commented 3 years ago

Take a look at #147 In an upcoming release - only the dist folder will be published (to npm) : I have added a post build script to copy the images to the dist folder

khushal87 commented 3 years ago

Okay, then I am closing this PR. Only one doubt, is it good to have the images folder inside dist? @sshivananda

sshivananda commented 3 years ago

I have seen both implementations

Here's my opinion

khushal87 commented 3 years ago

Yes according to me both are fine, its your call you can choose any. You are correct in what you mean 💯 @sshivananda