search

Montellese / mediaimporter.emby

Media importer add-on for Kodi to import items from Emby servers into Kodi
GNU General Public License v2.0
12 stars 3 forks source link

Import Boxsets #3

Closed Long-Man closed 4 years ago

Long-Man commented 4 years ago

This is what i found in Emby for Kodi with respect to boxsets/movie sets https://github.com/MediaBrowser/plugin.video.emby/blob/4f9d2d54315a52e8764b43dd97576876e7c89113/resources/lib/library.py#L602

https://github.com/MediaBrowser/plugin.video.emby/blob/4f9d2d54315a52e8764b43dd97576876e7c89113/resources/lib/sync.py#L474

Montellese commented 4 years ago

5c999447ecf410c1e34b6f26bd86f456eab4ba5f adds basic support for retrieving BoxSets from the Emby server and matching them to the movies belonging to the BoxSets. But there is no support yet for also synchronizing the BoxSets details like artwork or overview. This will require changes in the media import implementation in Kodi.

Long-Man commented 4 years ago

I can confirm that the boxsets have been imported. There are also accurate to the corresponding libraries. ie Kids Movies has boxsets of Kids Movies, Documentaries has boxsets of documentaries etc. And without a filter, one can see all boxsets. Great Job. You said basic support. What do you consider as missing?

Montellese commented 4 years ago

As mentioned it currently only assigns boxsets by name to movies. It does not import artwork or the overview of a boxset into Kodi.

Montellese commented 4 years ago

I've started extending Kodi's media import logic to also explicitly import BoxSets / Collections / Movie Sets, see https://github.com/Montellese/xbmc/issues/63. I've created the branch feature/import_boxsets in this repository with the necessary changes for Emby. It seems to work i.e. Kodi now also imports the artwork and summary / overview of the BoxSets.

As soon as I've tested it some more and implemented it for mediaimporter.plex as well I'll merge it into master.

Long-Man commented 4 years ago

Sweet. Does it work with the last build or do a need a new kodi build?

Long-Man commented 4 years ago

Never mind. Just realized a a new build is required

Montellese commented 4 years ago

I've merged the full implementation into master and it will be available with the next test-builds and https://github.com/Montellese/mediaimporter.emby/releases/tag/0.0.4.