HTTPS support - Githubissues

Montellese / mediaimporter.emby

Media importer add-on for Kodi to import items from Emby servers into Kodi

GNU General Public License v2.0

12 stars 3 forks source link

HTTPS support #9

Open Montellese opened 4 years ago

Montellese commented 4 years ago

Right now the add-on only supports connecting to an Emby server using HTTP. HTTPS is not supported. It must also be possible to bypass HTTPS server certification validation by appending |verifypeer=false to URLs passed to Kodi.

[ ] How can the add-on determine that it should use HTTPS?
[ ] Make certificate verification configurable / optional.
- [ ] Tell requests and websocket to ignore self-signed certificates.
- [ ] Append |verifypeer=false to every URL directly used by Kodi.

Montellese commented 4 years ago

If the user manually adds the media provider and provides an HTTPS URL this seems to work in general.
If the media provider is auto-detected it always uses HTTP. How can the add-on determine that it should use HTTPS?
If the media provider uses a self-signed HTTPS certificate all requests directly from Kodi will fail and require |verifypeer=false in the URL.

darthShadow commented 4 years ago

Would it be possible to also consider HTTP/2 support as a part of this issue? Plugging in the hyper library into requests for HTTP/2 support is only a single-line addition and should be backwards compatible.

Documentation: https://hyper.readthedocs.io/en/latest/quickstart.html#requests-integration

I can create a separate issue for this if you would prefer that.

Thanks.

Montellese commented 4 years ago

Yes please create a separate issue. Do you happen to know whether hyper is available as a module in Kodi's python environment?

darthShadow commented 4 years ago

Done. #33

Do you happen to know whether hyper is available as a module in Kodi's python environment? Sorry, not sure of that.