search

Montellese / xbmc

Montellese's fork of Kodi
http://kodi.tv
Other
21 stars 6 forks source link

Unify music window #48

Closed notspiff closed 9 years ago

notspiff commented 9 years ago

Hi, this is my work so far for unifying the music files/nav library like for videos.

i send the pull here so we can hopefully avoid all the goons. not sure if you have any interest but you are the only one i can think of who might have.

keep in mind that this is mostly moving code around, cosmetics are not the focus. we can always address those as well but please let's stay focused on the functionality for now.

there is still some context menu cleaning to be done but damn we need a better system for that. it always turns into horrible spaghetti code. other than that i have tested most things and they seem to work (scans, deletion etc).

the base window is of questionable use now, like for videos. but step by step..

Montellese commented 9 years ago

Cool thanks. I will take a closer look sometime this week (hopefully tomorrow). I'm certainly interested as it's the one major inconsistency between the video and music library integration right now. Matthias might be interested as well as he has done quite a bit of work in the library area lately (like the library node support for the music section).

notspiff commented 9 years ago

or is it @mkortstiege

Montellese commented 9 years ago

Yup it's @mkortstiege.

I've gone through all commits except for the context menu ones (which are a bit more complex) and only spotted a few minor things. Great work.

Montellese commented 9 years ago

Before I forget this probably also needs adjustments in Confluence:

mkortstiege commented 9 years ago

Nice! I think mymusic.startwindow can be nuked entirely as well? Will give it a try over the weekend and report back.

Montellese commented 9 years ago

@mkortstiege: I thought that as well at first but it can store a path to any library node like Albums or Artists etc.

mkortstiege commented 9 years ago

Oh, makes sense now. Just did a quick grep and noticed that settings has no label and that there's no obvious video counterpart. Thanks for explaining.

ronie commented 9 years ago

changes for confluence: https://github.com/ronie/xbmc/commit/99d0a39eeb85c07d99ec21b8ca473e5f5e40ff25

Montellese commented 9 years ago

Once again thanks a lot for your work on this. I finally found the time to rebase it and PR it against master at https://github.com/xbmc/xbmc/pull/8011.