search

Montreal-Analytics / dbt-snowflake-utils

Snowflake-specific utility macros for dbt projects.
Apache License 2.0
105 stars 36 forks source link

feat: add environment variables for tag database and schema #49

Closed arjunthangaraj closed 9 months ago

arjunthangaraj commented 11 months ago

This PR is for adding the environment variables for tag database and schema which should allow users to create the tag in different centralised location and use it in the models. This is for the issue mentioned here.

If not given any environment variables, the existing functionality will not get affected and tags will be created in the same database and schema as models.

README.md has been updated with the details and it is tested with the sample model on dbt v1.6.

daniepett commented 11 months ago

Hi @jamesweakley, any chance this could be reviewed? This feature would be really useful for us. Really appreciate the work you've done on this package.

jamesweakley commented 11 months ago

Hi @arjunthangaraj, apologies for the delay. The change looks good to me, thanks for contributing it.

I can't approve the merge but hopefully @JFrackson or another maintainer can.

daniepett commented 10 months ago

Hi @JFrackson, @mbhoopathy, @alfredodimassimo. Any chance we can get some reviews on this? :) Thanks

arjunthangaraj commented 9 months ago

Hi @JFrackson @alfredodimassimo @mbhoopathy , Could we get some reviews on this please? Thanks.

JFrackson commented 9 months ago

Thanks for this change and sorry about the delay with the review! Merging and releasing now