MontrealCorpusTools / ISCAN

Development repository for Integrated Speech Corpus Analaysis (ISCAN)
MIT License
9 stars 0 forks source link

"encoded acoustics" confusing #73

Closed msonderegger closed 6 years ago

msonderegger commented 6 years ago

Currently in the Corpus view, if you've encoded FAVE-style formants or spectral measures, these will show up under "Currently encoded properties" for Phones, but nothing will show up under "Currently encoded acoustics" for Acoustics.

I see the logic of this (FAVE-style formants are single measures that are properties of phones), but it's potentially confusing because the user originally clicked "Acoustics" to make the enrichment.

I think Acoustics in corpus view currently only shows encoded tracks. maybe it should show point measures as well, even if these are duplicates? not sure..

mmcauliffe commented 6 years ago

An easy fix would be to be explicit that it's only encoded tracks that are listed there?

The issue with point measurements showing up there is that there's no difference in the database between F1 and begin. If we wanted them there then the Enrichment object would have to know what it's encoding, which it currently doesn't.

msonderegger commented 6 years ago

I think it's fine they show up there. I was thinking maybe also under Acoustics, but perhaps that's confusing.

Maybe just change "Acoustics" in corpus view to "Acoustic tracks" or something?

mmcauliffe commented 6 years ago

Yeah, changed it to acoustic tracks, which are in their own section because the point measures already have a way to view if they're encoded.

msonderegger commented 6 years ago

Great.

Btw should I have marked this low-priority? I guess I have been assuming that "suggestion" implies low-priority. (This issue didn't need to be addressed ASAP.)