Montspy / LooPyGen

Loopring Python Minter on Layer 2
17 stars 6 forks source link

PHP UI for JSON Traits #34

Closed sk33z3r closed 2 years ago

sk33z3r commented 2 years ago

Initial UI in place where users can manually add in the trait information into a web form, instead of editing JSON directly.

Features to be implemented before merge:

We'll create other pull requests for future features here, like running the whole process from the UI.

sk33z3r commented 2 years ago

@Montspy

Note about directories:

I got rid of the example collection_name folder since the UI will handle this, and moved images to collections. I think it is more fitting to how things are structured now. I didn't actually make this change, I thought I did.

Notes about the JSON traits output:

Rarity Value
Legendary 1
Rare 2
Uncommon 3
Common 4

I think this will work properly, but perhaps we need to adjust those values.

sk33z3r commented 2 years ago

Couple other notes:

sk33z3r commented 2 years ago

@Montspy I moved the mint address back to config. I kept thinking about it, and I think that maybe can stay in config since it's related to minting specifically.

If we desire, we can always pull the address from the config and place into the metadata on generation.

Otherwise, I changed up endpoints a little to get setup for new features:

The page exists, but editing mechanism isn't there yet, for these:

sk33z3r commented 2 years ago

@Montspy finally remembered to put collection_lower in the json...

sk33z3r commented 2 years ago

@Montspy this PR is ready when you have your side sorted and confirm there are no more changes needed in PHP. I opened other tickets since I think it is in a good enough place for testers.

Before we attempt to merge, should we review and merge in #30 first?

Montspy commented 2 years ago

@sk33z3r I think we should merge this before #30 simply because we've both tested this branch more than #30. In terms of merge conflicts, I don't see a big difference in the merge order between this branch and #30.

I released a new version of LooPyMinty for this branch, make sure to update your submodules! This new release adds: