Montspy / LooPyGen

Loopring Python Minter on Layer 2
17 stars 6 forks source link

[python] Filter out "*Zone.Identifier" files #49

Closed Montspy closed 2 years ago

Montspy commented 2 years ago

Windows can create Zone.Identifier files when files are downloaded from the internet, copied to WSL via the windows file explorer. This confuses the glob filter that looks for files when creating CIDs and can lead to invalid CID pre-calculation.

The real solution should be Windows to fix their 6 year old bugs. As a workaround, we should add a filter to exclude those files from the glob result

image

Montspy commented 2 years ago

Implemented workaround that filters out files with extension of length > 4 from the glob result in PR #47 (commit 07d76bc59864892d936728bb53a4ecc6fcd2a46b) Will close when PR #47 is merged into main