WT: Multiple issues present

Castigavi commented 5 years ago

MAIN WINDOW:

[x] "Destination WAD" and "Source WAD - WAD2 - Level" are confusing. Call destination "FINAL WAD" and source "ASSETS WAD" or "REFERENCE WAD".
[x] Rename "Open Destination" to "Load WAD" and rename "Open Source" to "Load Assets WAD" or "Load Reference WAD".
[x] "Save wad2 as..." is redundant as it can only save wad2 as wad2.
[x] Double clicking on category (eg. Movables) opens Animation Editor of the last selected object. It should create new empty slot instead. Works with left and right mouse button.
[x] ERROR/WARNING prompts are too intrusive. They should be handled like prompts in TE (so only as a prompt that doesn't require clicking, but disappears by itself).
[x] If you create an empty movable, then click on Edit Animations, unhandled exception occurs.
[x] If you create an empty movable, then click on Edit Skeleton, unhandled exception occurs.
[ ] SHIFT + double click on object in Source WAD should copy its content to first empty slot of similar name in case of movables and to next empty slot in case of statics.
[x] You can edit objects of SOURCE wad, but you can't save changes to the file and there's no indication that a change has been made. The only way to keep changes is to copy object to the FINAL wad.
[x] "Add object to different slot" works EXACTLY the same as "Add objects" and shows "Occupied slot" window.
[x] "Edit" button does not work.
[x] Right clicking on object should give options to remove or change slot.
[x] There is no indication that a project and/or object has been changed. A * symbol should appear next to wad/object name like in case of TE.
[x] There is a weird thing beneath preview, with two buttons and slider, that is greyed out most of the time but sometimes becomes active and breaks objects when used.
[x] Camera movement in EVERY object preview (so also in all editors) is not consistent with TE and confusing.
[x] If you remove old object from FINAL WAD, then add new object in its slot and try to edit it, meshes and everything from old object will appear.
[x] This issue might be because of the one above, but erratic behavior has been observed with PUZZLE_ITEM1_COMBO1. In WADTool it shows PUZZLE_ITEM1 mesh in Skeleton Editor and Animation Editor, but in preview correct mesh is present. This probably happened because I have removed object from PUZZLE_ITEM1_COMBO1 slot which had PUZZLE_ITEM1 mesh applied, then copied new item into PUZZLE_ITEM1_COMBO1 slot again and loaded new mesh into it. Ingame when object is picked up, both meshes are shown. Attached wad2 file, obj files and video of the issue. puzzle_item_1.zip
[x] (Applies to all windows actually) WADTool cannot render alpha channel AT ALL. Also magenta (and probably 0,0,0,0 black colour) clears everything in its way, meaning you can't see past it even though magenta itself is not rendered.
[ ] There is no way to copy and paste slot. You can only replace FINAL wad object with SOURCE wad object. There should also be an option to copy slot (from any wad) and paste or replace it in FINAL wad.

SHARED EDITOR WINDOWS PROBLEMS:

[x] Blue background does not fit the UI , it is uneasy for eyes and it is inconsistent with TE UI design.
[x] There is no way to export models.
[x] GIZMO is too big and obscures small objects
[x] There is no way to move objects more precisely. You can only do that with GIZMO, which is imprecise. Some fields where you could change x y z values of object would be good.

MISSING FEATURES:

[x] TRLE legacy waterfall textures - the waterfall objects used eg. in ANGKOR levels. You can easily do that using strpix, but there is no functionality for that in WAD Tool.
[x] Blending modes - originally PC TRLE only used additive blending mode. PSX versions and FLEP patched executables offer many more blending modes. Wad Tool should have the ability to create texture that use all of the available blending modes, just like Tomb Editor does now.
[x] Shine - legacy TRLE levels often use shine on objects, especially those in the inventory menus, but also Lara's golden doppelganger in karnak levels. This ability is easy to achieve in strpix, but impossible in WADTool.

ANIMATION EDITOR:

[x] ANIMATION 0 is not loaded when editor is opened (even though it is selected), resulting in unexpected behavior like being unable to select meshes, edit them etc.
[x] There is no visual indication that you have clicked any of the buttons.
[x] You cannot copy frame and paste/replace it several times in a row. Same applies to copy animation.
[x] Delete animation and Cut animation buttons have the same behavior (they delete anim).
[x] Cutting/deleting last frame results in unhandled exception.
[x] There is no way to change ID of animation. This makes it impossible to add animation with ID 0.
[x] There is no way to remove bounding box/collision of entire animation.
[x] Clicking on timeline results in erratic behavior of the blue pointer.
[x] Frames on timeline should be counted like in 3ds max (each frame if a small number, every 5th/10th for larger number of frames).
[x] There is no way to import and export animations to external 3d apps like 3ds max, blender.
[x] There is no way to select a mesh by clicking on it, but you can easily unclick it.
[x] There is no way to SAVE changes before closing window. They are saved automatically which is different from Static Editor.
[x] It seems GIZMO is always centered on object even if object's pivot is not in its center.
[x] Play button does not work.
[x] Recalculating collision box seems to break interactive objects. Tried to recalculate it for TURN_SWITCH, but it only resulted in the object having no collisions at all. Because of that the object isn't usable anymore. Also pushable sound for the object is broken. Attaching zip with two wad2 files for reference. turn_switch.zip

STATIC EDITOR:

[x] There is no way to switch between STATIC and DYNAMIC lighting.

SKELETON EDITOR

[x] If user creates a new, empty movable, then opens Skeleton Editor and tries to directly load a new mesh (so root bone is not selected), unhandled exception occurs.

MontyTRC89 commented 5 years ago

Frames on timeline should be counted like in 3ds max (each frame if a small number, every 5th/10th for larger number of frames). We can't because TR supports only keyframe animations.

Castigavi commented 5 years ago

What do you mean by this? Even WADMerger has counted frames:

obraz

Are we talking about the same thing?

MontyTRC89 commented 5 years ago

ok now I understand :) I could do this, but only keyframes will be editable.

Castigavi commented 5 years ago

The numbers will be only for visibility as it makes frames easier to read. Although you could also add something to show where flipeffects or transitions are (like the blue/green squares in Wadmerger, seen in above screenshot).

MontyTRC89 commented 5 years ago

(QUESTION) should it be possible to edit animations/bones/models of SOURCE WADs, if you can't save them anyway?

Yes it's possible, just tried.

Castigavi commented 5 years ago

The question was if it should be possible, as in, permitted by the application. It is impossible to save SOURCE wads, so why would it be possible to modify them if you can't save changes?

If it's a design choice that source wads can be modified though (even though you can't save changes to them), there should be a visible marker to indicate that the object has been modified. For example the * symbol that appears in Tomb Editor once something's been changed within the project.

EDIT: I have edited that question and turned into into a straightforward bug. Up to you guys to decide how this case should be handled.

Castigavi commented 5 years ago

@MontyTRC89 added new issue to the list, found by Lore again. Skeleton Editor crashes if you load model without selecting root bone first.

Castigavi commented 5 years ago

@MontyTRC89 there is still crash in WADTool when loading model in Skeleton Editor while root bone is not selected.

Joey79100 commented 5 years ago

A few additional issues with the animation editor:

[x] When an animation uses acceleration, Start vel and End vel are broken.
[x] Scrolling the animation list scrolls too much lines, which makes it unusable. It skips about 110 animations, or even more if the window is smaller.
[x] State Changes and Anim commands windows are modal, they should not. We sometimes need to see some frames in detail (by manually dragging from one frame to another) to make a decision.
[ ] Moving the camera one way or another stops animation playback until we stop moving.
[x] Bounding box panel: the buttons have no text so they need a tooltip, but they don't have that either.
[x] Some gizmos seem to have priority over the other ones sometimes: depending on how they're setup and the camera angle, it is hard to select one, because another one will be highlighted instead of the one the mouse is actually hovering.
[x] Typing a number in the animations list won't return the animations with that index. This looks intentional, because it allows searching for name and StateID. But there is no quick way to jump to an animation number. One possibility could be to jump to an animation by its index when typing it in the animation list (when the list has the focus, ie. when you click on an animation and then type a number).
[x] Pressing enter when changing the name of an animation triggers the windows default sound (when you're trying to do something you can't do). It could instead update the name of the animation in the list.
[x] Rendering > Draw collision box has no effect.
[x] With the newly implemented chain-mode: 1) Select an animation 2) Turn playback on 3) Select another animation 4) Turn chain mode on 5) Turn playback off -> it jumps back to the animation selected in step 1)
[x] Activating real-time sound playback throws an exception if the opened PRJ2 is using the old sound system.

MontyTRC89 / Tomb-Editor

WT: Multiple issues present #310