search

MontyTRC89 / Tomb-Editor

Tomb Editor
57 stars 16 forks source link

TE: "Glow" value intensity doesn't have impact #777

Open StarringRole opened 6 months ago

StarringRole commented 6 months ago

Back in TE 1.2.7 I believe (long time ago) glow used to have more impact on the appearance of water creating a deeper and more intense effect, is it possible this can be restored? (For TRNG specifically)

In an older TEN version (I haven't tested current versions) it worked how it used to in TE for TRNG.

I can provide an example of it in TEN, but without older builds of TE I can not recreate a preview in TRNG.

Left Intensity 1 Right side intensity 4

This same effect used to work for TRNG in TE but hasn't for a very long time now.

https://github.com/MontyTRC89/Tomb-Editor/assets/35333139/1c7f7e79-8d53-4c0e-a507-05292e687dc4

Nickelony commented 5 months ago

Wait, I'm lost, so right now in 1.7, changing effect strength doesn't affect both TEN and TRNG levels?

Edit: I just tested on TRNG, Glow 1 and Glow 4 definitely look different. Glow 1 looks finer, while Glow 4 seems to have larger light and dark areas, but the brightness levels are unaffected, unlike in the video you posted.

Also, I noticed that "Glow & Move"'s brightness does drastically change, depending on the intensity, so maybe the "Glow" only intensity never affected brightness in the first place? I think someone else needs to have a look at this.

Lwmte commented 5 months ago

TE 1.2.7 was a really ancient version and there were many problems with room vertex effects fixed since then. I think that in 1.2.7, more bright glow was a result of a bug, and not a feature which was broken in later versions.

Nickelony commented 5 months ago

Yea, I read the code and there didn't seem to be anything off. Testing various settings does yield different results (as expected), that is, the differences are quite hard to spot, but they are definitely there. Not sure what to do with this issue then.