MontyTRC89 / TombEngine

A new custom Tomb Raider engine based on TR5 engine
MIT License
64 stars 16 forks source link

Avoid crashing when slots are missing #1088

Closed Joey79100 closed 1 year ago

Joey79100 commented 1 year ago

TEN tries to render lots of things without checking first if the required data is there first. Most common example recently: a missing object in the WAD, such as bars sprites. The consequence is a plain crash, with no information to help users.

When possible, checks should be done: if some required data is missing:

Here is a list of slots that do not already have such checks, and could use some (with no particular order). Feel free to amend. I just did the few I found from running a "converted" TRNG level with missing sprite objects, and didn't look much further.

Moveables

Sprites

Other

Joey79100 commented 1 year ago

Just a did a few on branch warning_not_crashes with 4af6f4999

For some reason Github won't list my branch when trying to link it manually from the issue, and I didn't think to mention the issue in the commit's comment.