search

MonumoLtd / SimpleGA.jl

Geometric algebra in Julia.
MIT License
23 stars 2 forks source link

Ga31 #7

Closed chrisjldoran closed 1 year ago

chrisjldoran commented 1 year ago

Two main improvements:

  1. A new base algebra has been added, G(3,1).
  2. Most issues with accidental conversion to Float64 have been resolved, and new tests have been added for this.
tpgillam commented 1 year ago

The tests aren't passing... :)

Running autoformat in VSCode should get rid of the linter errors. But I think the main problem is that your new file is called GA31.jl rather than ga31.jl...

I'm guessing you're using windows natively rather than WSL? Because windows uses a case-insensitive filesystem (groan groan groan), it means that the tests will pass for you but fail here, because the CI runners will be using a case SENSITIVE file system.

Anyway, I'll take a proper look at this tomorrow once there are more green ticks and fewer red crosses :)

chrisjldoran commented 1 year ago

Sorted the naming issue with AG21.jl and that fixed all the errors. Still do not understand why the formatter keeps suggesting changes that don't actually change anything.

db434 commented 1 year ago

Still do not understand why the formatter keeps suggesting changes that don't actually change anything.

It looks like it's suggesting a newline at the end of the file. This is useful because it stops multiple files running together in bigger diffs and giving odd results.