Closed TheDuckCow closed 2 years ago
-MrYyXulO3-4rR0Dlfo-
: I'd suggest having a try catch loop to handle the errors-Mm8BSy1cLw9UgTAdlAt
: This seems interesting. I'd assume filepaths were done in a cross platform way(though this could be a Windows issue). I'll take a closer look once I get back from vacation-Mpl6MOu1M6JEgEpTfaS
: This one is also pretty interesting. If the reports have Blender versions, which version has this issue the most. This might be fixed with a try catch loop. My suspicion is that it's a issue in older versions of Blender. All of these seem interesting, but I'll have to take a look when I get back
Sounds good! I'll not focus on those ones first, but if I do finish other tasks up I'll comment back here before working on them to avoid any overlap. No rush and no worries if you don't end up having time, appreciate your willingness!
FYI I'm going to start tackling a few of these which are most critical, I'll be fixing the following at a minimum hopefully:
Any that you get to that I don't can still be included in a near-after update of course! And if I end up ambitiously solving more than the two above, I'll tick the boxes above as complete.
Marking -Mm8BSy1cLw9UgTAdlAt
resolved with https://github.com/TheDuckCow/MCprep/commit/55719ce2b1faa3d007f6b2c69c7d0083ac26a90a
Marking -MhtywSS5IU1Wwc9WvlI
as "done" but really nothing was or could be done. It could be due to any number of OS issues, and specific errors are not passed forward by the function call to save the image constructed. Very few people have run into this.
Marking -MoSSh6nd09YGfF7gEp_
as done as it is already handled with try/except around the obj importer operator (this is not actually MCprep code).
Marking -MhwacqY_LI2NQ-7TijV
as a try-except was added around the one line. Still seems like a bug that we need to try catch at all here, but will unblock some users hopefully.
Have not seen a way to resolve -MfrrPFH3udKVFiitSLr
, but I do not only 4 reports of this happening, and all blender 3.0+ on Windows and some (not all) from the current version of MCprep.
Marking this issue as closed; not all were resolved, but enough that we shouldn't hold up future development as well as other now more commonly auto reported bugs.
Listing below a barrage of bug reports that have multiple loggers. I will attempt to resolve all of these bugs, knowing some of them are blender version specific. ID's listed here are from the MCprep issue reporting database, which I use privately to track fixes. These are ordered in frequency of reports and number of users. Likely not all will be resolved for the target milestone. These are the top 11 I am focussing on for this iteration, will edit if others are resolved and reference this on release update.
-MobC6QO1QmbzwxXV0XE
: moonmesh.parent = get_time_object()\nTypeError: bpy_struct: item.attr = val: Object.parent ID type does not support assignment to itself\n-MrYyXulO3-4rR0Dlfo-
: UnicodeDecodeError: 'utf-8' codec can't decode byte 0x8b in position 1: invalid start byte\n, This is actually an issue with the obj files themselves, but MCprep could do better about telling the user something useful like "Try re-exporting your world" or "World cannot be read, may be corrupted". At the risk of PII I may consider also logging filenames, since this happens frequently enough it's worth understanding what people are actually attempting to do (are they selecting .zip files or something?)-MfrrPFH3udKVFiitSLr
: context.object.material_slots[mat_ind].material = mat\nAttributeError: bpy_struct: attribute "material" from "MaterialSlot" is read-only\n-Mpl6MOu1M6JEgEpTfaS
: enum "Non-Color" not found in ('Linear', 'sRGB') (many variations of this one, may not be able to do much about it)-MhJp--Z7JIfZnnw45w1
: During item spawning (from list or file): RuntimeError: Operator bpy.ops.object.mode_set.poll() failed, context is incorrect\n, I am doubtful I'll be able to find a simple fix for this one and seems very contextual. A geometry nodes alternate may be viable, though not backwards compatible.-MoSSh6nd09YGfF7gEp_
: loopsuv = tuple(uv for (, _, face_vert_texindices, , , , _) in faces\n File "-MhwacqY_LI2NQ-7TijV
: asum += data[fnd][image.size[1]*row + col]\nIndexError: list index out of range\n (likely related to the above)-MgRXi1HSdOt7R23ZAZx
: method, block = self.block.split("/")\nValueError: not enough values to unpack (expected 2, got 1)\n, should more gracefully recover from this, though may be a legitimate upstream bug.-MhtywSS5IU1Wwc9WvlI
: RuntimeError: Error: Image 'water_still-seq-temp.001' could not be saved to 'textures\water_still\water_still_0001.png'\n\n, Let's at least create a better logging statement and more narrowly capture what error occurred to give a useful instruction (e.g. permission error? diskspace?)-Mm8BSy1cLw9UgTAdlAt
: Looks like an os path based issue: ...mcprep_default/assets\minecraft\textures\block\grass_block_side.png': No such file or directory\n\n-Mp-x0eXahGbiDeA3mkM
mcmeta = json.load(mcf), raise JSONDecodeError("Expecting value", s, err.value)-MfnEBOpGxyEReFtGtNU
load_linked\n act = context.selected_objects[0]If anyone is curious about how issue tracking works, please see more information here.