Moo-Ack-Productions / MCprep

Blender python addon to increase workflow for creating minecraft renders and animations
https://theduckcow.com/MCprep
GNU General Public License v3.0
285 stars 24 forks source link

Selecting alpha faces is running wrong when your image resolution ratio is not 1:1 #376

Open Kenimation opened 1 year ago

Kenimation commented 1 year ago

Did the issue happen after restarting Blender?

Check known issues

What happened?

Selecting alpha faces is running wrong when your image resolution ratio is not 1:1. When I am using selecting alpha in 64x64 or 16x16 images it works well. But in some cases such as 15x16 or 60x64 images, it doesn't work correctly.

What steps are needed to produce the bug?

To use selecting alpha in 15x16 or 60x64 images, doesn't work correctly.

What version of MCprep are you using?

MCprep 3.4.1

What version of Blender are you using?

Blender 3.4

StandingPadAnimations commented 1 year ago

Can you show a screenshot of the console?

Kenimation commented 1 year ago

image image You can see the first image. The alpha faces selection is broken. But it works well in 16x16 images.

StandingPadAnimations commented 10 months ago

Following up on this, I think we should work on a new route to detect alpha faces. The existing algorithm just approximates, so it's not perfect, but I think it can be made better

StandingPadAnimations commented 10 months ago

I'm marking this as a bug since it's a regression in the algorithm we use