Moo-Ack-Productions / MCprep

Blender python addon to increase workflow for creating minecraft renders and animations
https://theduckcow.com/MCprep
GNU General Public License v3.0
283 stars 26 forks source link

Warden causing Reload Mob errors in 2.8x and 2.9x #403

Closed TheDuckCow closed 1 year ago

TheDuckCow commented 1 year ago

For some reason, 2.8x and 2.9x users are encountering errors when importing specifically the warden rig:

File "<addon_path>/mobs.py", line 206, in execute
 update_rig_list(context)
 File "<addon_path>/mobs.py", line 148, in update_rig_list
 _add_rigs_from_blend(blend_path, blend_name, category)
 File "<addon_path>/mobs.py", line 65, in _add_rigs_from_blend
 with bpy.data.libraries.load(path) as (data_from, data_to):
 OSError: load: C:\Users\{REDACTED}\AppData\Roaming\Blender Foundation\Blender\2.91\scripts\addons\MCprep_addon\MCprep_resources\rigs\hostile\Warden - DigDanAnimates.blend failed to open blend file

I see no reports for Blender 3.x implying it's a compatibility problem. This is likely rig asset fix we need to make.

This accounts for 122 of the 704 bugs reported in the last few days. As a breakdown of current bug reporting:

TheDuckCow commented 1 year ago

There is also a more general improvement that should happen, apparently the issue is happening actually during "mob reloading", so really any flaky mob model will break the loading of all of them. We should likewise make mob lading much safer during the reading of a blend file, fail by skipping that single entry.

StandingPadAnimations commented 1 year ago

I see no reports for Blender 3.x implying it's a compatibility problem. This is likely rig asset fix we need to make.

I sense a perfect "first contribution" type issue for new developers

TheDuckCow commented 1 year ago

I would agree would ordinarily be a good first contrib, but there's some strong urgency behind this one that we'll want to resolve it in the next couple days.

I just did a test myself, and I'm not seeing any issues loading the warden rig there. I am using blender 2.90. Looking back at the error reporting database, I see:

Full blender version list with at least 1+ report (so once again, seems like a pretty even spread of version ≥ 2.80 and < 3.0)

(2, 93, 9)
(2, 93, 8)
(2, 93, 6)
(2, 93, 5)
(2, 93, 4)
(2, 93, 3)
(2, 93, 2)
(2, 93, 15)
(2, 93, 14)
(2, 93, 1)
(2, 93, 0)
(2, 92, 0)
(2, 91, 2)
(2, 91, 0)
(2, 90, 1)
(2, 90, 0)
(2, 83, 5)
(2, 83, 20)
(2, 83, 2)
(2, 83, 0)
(2, 82, 7)
(2, 80, 75)

We will need to see if we can reproduce this on a windows machine, I'm scratching a head a bit on why I can't get the error. The volume of errors is very substantial, so a large quantity of people for sure are running into this.

CFeeney333 commented 1 year ago

image hmmm.... happened for me on windows. blender 2.93. when i click reload mobs if the problem is with the model/rig, how can we fix the issue?

StandingPadAnimations commented 1 year ago

What I find strange is that the error is saying Blender couldn't open the file. I wonder if Blender has some form of internal logging we could take advantage of

TheDuckCow commented 1 year ago

Thanks for sharing @CFeeney333

So something interesting I notice is that it says MCprep v3.4.1 - did you just install the most recent version of the addon? Did you restart after the install? And how did you do the install - manually by going to edit > preferences > addons > install addon, or using the one-click button in MCprep itself? edit: Also meant to ask, did you have MCprep installed before this most recent install; I assume yes, since it says MCprep v3.4.1

Also, can you confirm if you can manually open the path of the Warden DigiDanAnimates files as a blend file as a user? It would be in your app roaming folder, blender 2.93 scripts / addons / MCprep / MCprep_resoruces / mobs / hostile folder (path name is approximate ofc).

We're a bit blind until we get more details, so I appreciate your help here

CFeeney333 commented 1 year ago

405 gave the issue a look over myself here, so no worries