Outstanding UAT fixes for 3.6.0

TheDuckCow commented 4 months ago

From the prior PR, there's a couple outstanding items before we release:

[x] Find missing textures is not really working well, at least for jmc2obj. I will review in another branch as I've started troubleshooting
[x] When all textures are missing, Prep Materials also wrongly says "no materials found to modify", which kind of doesn't make sense - even if textures are missing, it should be able to prep them (and per above, if the tick box is selected, should replace the missing textures)

[x] Blender 4.2 has an error when trying to use the geo nodes weather effects, see:

mcprep_addon dev response (requests lib) {'name': '-O19oCElybIt7FYFJ2bf'} at /1/track/usage_dev.json
Traceback (most recent call last):
File "/Users/patrickcrawford/Library/Application Support/Blender/4.2/scripts/addons/MCprep_addon/tracking.py", line 887, in wrapper
res = function(self, context)
      ^^^^^^^^^^^^^^^^^^^^^^^
File "/Users/patrickcrawford/Library/Application Support/Blender/4.2/scripts/addons/MCprep_addon/spawner/effects.py", line 1057, in execute
add_geonode_area_effect(context, effect)
File "/Users/patrickcrawford/Library/Application Support/Blender/4.2/scripts/addons/MCprep_addon/spawner/effects.py", line 113, in add_geonode_area_effect
geo_update_params(context, effect, geo_mod)
File "/Users/patrickcrawford/Library/Application Support/Blender/4.2/scripts/addons/MCprep_addon/spawner/effects.py", line 469, in geo_update_params
geo_mod[geo_inp_id[inp.name]] = value
~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
TypeError: Cannot assign a 'float' value to the existing 'Input_18' Boolean IDProperty

Each of these can be handled in their own specific, focussed small PR so we get into the practice of that. But we can link them back to this one single issue.

TheDuckCow commented 4 months ago

FYI @StandingPadAnimations that I'm assigning myself, but if you wanted to attempt any single one of these, just comment here before getting started. And yeah let's do 1 PR for each bullet above. I'll have more time later this week

StandingPadAnimations commented 4 months ago

The geometry nodes bug seems to be a noted breaking change: https://developer.blender.org/docs/release_notes/4.2/python_api/#statically-typed-idproperties

StandingPadAnimations commented 4 months ago

I've tracked it down to the assets themselves

{
    "Camera Weather Nodes":{
        "Snow": {
            "Weather Type": 0,
            "Camera Rotation": "CAMERA_OBJ",
            "Weather Folower": "FOLLOW_OBJ",
            "Density": 0.960,
            "Main Directioanl XYZ": [0, 0, -34.31],
            "Spread": 7.690,
            "Time": 76.32,
            "Directioanl Ratio": 6.37,
            "Chaos Ratio": 6.57,
            "Random Rotation Ratio": 2.3,
            "Scale Ratio": 0.54,
            "On\\Off Random Scale": 0.0,
            "Size of Single Square": 23,
            "Weather Grid Size x": 33,
            "Weather Grid Size y": 33
        }

Blender now enforces proper types for geometry node inputs, and "On\\Off Random Scale" is meant to be a boolean. Swapping the uses of float to boolean for that particular key resolves the issue

StandingPadAnimations commented 4 months ago

Here is the fixed JSON file for geometry node effects: weather_effects_geo_by_the3pooka.json

TheDuckCow commented 4 months ago

Awesome, thank you for looking into this one. I just tried it out locally, and indeed it works. All the more reason that (after this release) we should look into a dedicate assets repository, since there's not even any checked in code change to associate with this. Other sad thing is that users to manually install the update (ie not via the built in updater, but via the Install Addon in preferences method), will not have their json files overwritten because... well, that method of installing updates only overwrites .py files :/ but, if people run into errors, we can just instruct them to do full removals + fresh installs after restarting blender.

Will take a quick look tonight at the other two issues, to see if there's something I can chink away at.