Moo-Ack-Productions / MCprep

Blender python addon to increase workflow for creating minecraft renders and animations
https://theduckcow.com/MCprep
GNU General Public License v3.0
281 stars 26 forks source link

"0 materials affected" when attemping to swap texture packs #82

Closed FouriusVixen closed 5 years ago

FouriusVixen commented 5 years ago

The "Swap Texture Pack" button doesn't seem to work.

Tried it out with 3 texture packs; Faithful++1.14.x+v1.2, Stratum-2048x, and SapixCraft 256x MC1.14. Always get a "0 materials affected" message.

Click the GIF for a higher res version.

a6ecb7a9aa6570a194c7fff4812c5246

TheDuckCow commented 5 years ago

Hi there, I think from your screenshot you are correctly running this when you have the world selected in the 3D viewport (but double check that you are). My next debugging suggestion is, click farther into the texturepack folder, down into and inside of the block/blocks folder. I believe I have an update pending where I need to treat newer texturepack formats to support a change in subfolder name from "block" to also search for "blocks" (or maybe the other way around).

So, again at worst, click down into the root folder that has all the actual textures inside the resource pack. Let me know if that works for you!

FouriusVixen commented 5 years ago

Hey! I tried out your suggestions, but it seemed to only change 12/49 textures. 2019-08-2423-33-32

Voxybuns commented 5 years ago

That's because 1.13 changed a lot of the internal block names used in resource packs. Because MCprep doesn't recognize those changes yet, any post-1.12 resource pack will not work properly.

FouriusVixen commented 5 years ago

That makes sense, thanks.

I tried the Stratum-2048x-1.12.2 (which includes Specularity and Normal maps), and it produced this monstrosity. cc2ae8dbb0722650c721c69095205aef

But SapixCraft 512x MC1.11, worked just fine. So ill just use 1.11 ressource packs.

Voxybuns commented 5 years ago

Yeah, there were some changes with the Principled shader node in Blender 2.8, causing a bug where the normal map feeds into the emission input rather than the normal one. I already reported the issue, should be fixed in the next update, hopefully!

FouriusVixen commented 5 years ago

Alright, perfect, Thank you both so much for your guys' help!

TheDuckCow commented 5 years ago

Thanks @Voxolotl for adding in, and indeed - I am aiming to have all this fixed in the next version. I'm essentially working on a hyper mapping, of all the pre and post 1.13 names for blocks, for all of jmc2obj, Mineways, and MInecraft itself - and also try to intelligently build a fallback check so that even older texture packs can be used on new world (or newer packs, on old worlds). Makes it tricky, but in the works.