Moocar / logback-gelf

Logback plugin to send GELF messages to graylog2 server
Apache License 2.0
147 stars 59 forks source link

<fieldType> uses MDC name, not ES field name #35

Closed rblumen-symphony-commerce closed 10 years ago

rblumen-symphony-commerce commented 10 years ago

The documentation shows:

requestId:_request_id
    <fieldType>_request_id:long</fieldType>

Based on how the code looks and what I was able to get to work, should use the MDC key value, which in this case would be "requestId", not the ElasticSearch field name.

Moocar commented 10 years ago

I'm not following. The rest-resources typedFields.xml uses <fieldType>_request_id:int</fieldType>, which is reflected in the IntegrationTests. Or am I missing something?

rblumen-symphony-commerce commented 10 years ago

I was looking at the home page with documentation: https://github.com/Moocar/logback-gelf

Moocar commented 10 years ago

I'm still not following. Can you please send a PR that fixes it? That should clear up any confusion. Thanks