search

Mood-Global-Services / Coliseum-Smart-Contracts

Smarts Contracts Repo
MIT License
1 stars 0 forks source link

ex-dividend snapshot #1

Open Waltermelon-lang opened 1 year ago

Waltermelon-lang commented 1 year ago

https://github.com/Mood-Global-Services/Coliseum-Smart-Contracts/blob/0dfee6983564c458f7f8507b11e48344a1cb0dda/contracts/Yield.sol#L38C33-L38C33 Sourav

  1. the yieldToDistribute should preferably something that takes into account the ex dividend time which can be received and store before this transaction is invoked.
  2. Also perhaps the remaining 20% can be send to the owner, in order for this contract to not send 80 of the remaining 20% if it happens to be called twice
  3. For ETF the ex-dividend is usually quarterly.
souravmaji1 commented 1 year ago

okay l am making the changes according to this points

By the way this is a great idea to ensure we have received and calculated the yield funds before time of delivery and when the time comes we can smoothly send to the holders

Waltermelon-lang commented 1 year ago

yes thank you