Gamification, rebases #143 and #137, closes #129 and closes #130

MoodCat / MoodCat.me-Core

Welcome to MoodCat.me, the music platform of the future, available today. Join us in the adventure of finding and enjoying music geared to you!

http://moodcat.me

MIT License

3 stars 2 forks source link

Gamification, rebases #143 and #137, closes #129 and closes #130 #145

Closed jwgmeligmeyling closed 9 years ago

jwgmeligmeyling commented 9 years ago

Rebased on master
Using id instead of soundcloudId
Using authentication token for /me request
Front end issue: https://github.com/MoodCat/MoodCat.me-Frontend/pull/57

TimvdLippe commented 9 years ago

UserModel and UserAPI are completely untested, they should be tested.

SongAPI.approachSong() should also be tested. I would rename it though, since approaching seems a bit weird. Maybe SongAPI.setInitialVector()?

Apart from these 2 minor remarks, this branch can be merged!

P.S. I didn't verify with frontend though, so we might want to do that too and have full prove of this working version.

jwgmeligmeyling commented 9 years ago

Yup but this was already the case in the existing PR's that were OK'ed and I think its time to merge now. A full pass on the frondend on someone elses machine would be nice ( @GijsWeterings ?)

GijsWeterings commented 9 years ago

LGTM, Merging