search

MoodCat / MoodCat.me-Core

Welcome to MoodCat.me, the music platform of the future, available today. Join us in the adventure of finding and enjoying music geared to you!
http://moodcat.me
MIT License
3 stars 2 forks source link

Truncating of messages. Fixes #84. #166

Closed TimvdLippe closed 9 years ago

TimvdLippe commented 9 years ago

Fixes https://github.com/MoodCat/MoodCat.me-Frontend/issues/84

eanker commented 9 years ago

You can type as long as you want, it's only not showing. Don't we want to block the chat or so?

But for this, LGTM

jwgmeligmeyling commented 9 years ago

I'm going to think about this one for a sec.

jwgmeligmeyling commented 9 years ago

I wouldnot truncate, a truncated message makes no sense. We should consider this a bad request and throw an exception. And prevent in the frontend that such messages can be typed by setting a limit on the input field.

TimvdLippe commented 9 years ago

Changed to exception and a fail-fast approach.

jwgmeligmeyling commented 9 years ago

We need this, will merge! :+1: