search

MoojMidge / service.upnext

GNU General Public License v2.0
19 stars 5 forks source link

[Request] Add option to detect last chapter for Upnext popup #21

Open psp2111-ADSLGATE opened 10 months ago

psp2111-ADSLGATE commented 10 months ago

if it possible will you add an option to detect chapters/bookmarks in videos files, and use it as indicator for Next episode popup.

MoojMidge commented 10 months ago

I don't believe Kodi offers any method for a plugin to directly access this information.

Some information is partially exposed via infobools that are typically used by a skin, and this could theoretically also be used by a plugin, but I have never looked into it.

Are you encountering many scenarios where the detector does not work reliably?

psp2111-ADSLGATE commented 10 months ago

weird I have 3rd party addon installed with this feature and can be enabled with its built-in next episode popup. if you want to look into it here

Regular timed detector works perfectly fine. but it really hard to tune it with every show. for "Automatic end credits detection" I really dont know how it work exactly and enable it dose not seems to change anything?!

using 3rd party addon players with TMDbH.

MoojMidge commented 10 months ago

What platform do you use Kodi on? The automatic end credit detection probably won't work on Android and other low power systems using dedicated hardware video decoding that doesn't read back the video frame output from the renderer.

On systems where it can work, it attempts to detect end credits automatically.

weird I have 3rd party addon installed with this feature and can be enabled with its built-in next episode popup. if you want to look into it here

Yeah that uses the infobools I was talking about

psp2111-ADSLGATE commented 10 months ago

Mainly I use my PC Windows 11 with Nvidia GPU. So to use Automatic end credits detection I need to disable hardware acceleration?

Yeah that uses the infobools I was talking about

is it easy to add it or too much work and headache?

MoojMidge commented 10 months ago

Mainly I use my PC Windows 11 with Nvidia GPU. So to use Automatic end credits detection I need to disable hardware acceleration?

I don't have the same/similar hardware but it should work with HW acceleration enabled. If it doesn't work enable debug and detector debug logging in UpNext, send it through and I can have a look.

is it easy to add it or too much work and headache?

Shouldn't be too difficult, but no time at the moment.