search

MoojMidge / service.upnext

GNU General Public License v2.0
19 stars 5 forks source link

Playback continues after Still Watching popup closes without user interaction #34

Open MoojMidge opened 1 month ago

MoojMidge commented 1 month ago

I installed service.upnext-2.0.28+matrix.dev.0.zip

I'm having a separate issue with this release. Occasionally when I reach the end of unattended playback (1/1 for my test debug). I get kicked back to the skin but playback of the next episode starts and continues in the background of the skin.

Clipped_image_20240523_114639

https://paste.kodi.tv/elicidalar.kodi https://paste.kodi.tv/sisuninaqo.kodi

Originally posted by @booyakafoo in https://github.com/MoojMidge/service.upnext/issues/31#issuecomment-2127928245

booyakafoo commented 1 month ago

Sorry for the delay. I was doing some testing. Would like to update on what I have seen. Hopefully this makes sense.

When I installed your fix for issue #30 , https://github.com/MoojMidge/service.upnext/issues/30#issuecomment-2109147788 , I wasn't experiencing any issues with playback continuing in the background after the still watching popup closes without user interaction, when the countdown reaches zero, playback would stop properly. I was having the issue from #31, which was fixed in release v2.0.28+dev.0 (2024-05-23). After installing the new release I was having the playback continuing issue pretty frequently. So I went back to the fix/zip issued for 30 and manually added the fix for 31 https://github.com/MoojMidge/service.upnext/commit/6aaf633a27468297a1b2c30886abfd358d3d2da6

I have been using this for the last week or so on two TVs and I thought there was no still watching playback continuing issue, but it did happen one time today, to me it seems like it happens less frequently than I experience it with the full v2.0.28+dev.0 release though. It might just be random, I'm not really sure.

MoojMidge commented 1 month ago

It might just be random

Not random, but internal Kodi timing variations that make it difficult for an external plugin to check exactly what is happening in a deterministic manner. Need to think of the best way to handle it.