Moon-0xff / gnome-mpris-label

A music related GNOME extension.
GNU General Public License v3.0
51 stars 10 forks source link

Implement mouse thumb bindings #38

Closed Batwam closed 1 year ago

Batwam commented 1 year ago

Looks like I can create a pull request from your own changes! Changes look ok, however, on my mouse, 9 is forward and 8 back.

also, don't we need return Clutter.EVENT_STOP; each each of the case 8:/case9:

Moon-0xff commented 1 year ago

You are more than welcome to add more commits to the branch, i can't give you write access to the branch(i think) but you can fork it and add changes on your own.

I fork from your branches by adding the remote

git remote add batwam git@github.com:Batwam/gnome-mpris-label.git
git fetch batwam

This adds the branches of the remote (if the names doesn't collide), and i can switch, merge or any other action.

I remember something about upstream remote but i don't have it in my forks, and there's probably a way of doing it using the github web interface.

Batwam commented 1 year ago

Yeah, it's pretty straightforward, probably not worth a full blown branch PR for 2 lines of code (hopefully).

It a bit strange that your buttons would be swapped Vs mine. I'm judging forward/backward based on the action in the web browser. Are you confident your "forward" button is 8?

I also see from this page

the thumb-tip button is 9, and the inner-thumb button is 8)

Moon-0xff commented 1 year ago

They aren't. I didn't test the branch! 😁

Moon-0xff commented 1 year ago

I will push the changes then, let me know if something is missing

Batwam commented 1 year ago

Ok, that's good.

Just the return Clutter.EVENT_STOP which we should probably have for each case 8/9. Outside of that it's exactly the same changes I had proposed.

Moon-0xff commented 1 year ago

@Batwam is this branch working well? I compare it against #37 and it looks the same so I'm gonna go ahead and merge this.

Batwam commented 1 year ago

Yep, fine with me 👍