search

Moon-0xff / gnome-mpris-label

A music related GNOME extension.
GNU General Public License v3.0
55 stars 10 forks source link

Version 4 Development #3

Closed Batwam closed 1 year ago

Batwam commented 2 years ago

added button to turn on/off in settings. checks the status and hides the text if option is set and playback paused.

Moon-0xff commented 1 year ago

Have you tried it with other applications? Tried myself, and doesn't seem to have any effect :/

Batwam commented 1 year ago

yeah, it works for me with the Spotify app as well as Rhythmbox (although by Default, the "Alternative Toolbar" plugin is activated, at least in Ubuntu, which hides the volume button...). With chromium, it's always reporting Volume=1 regardly of what I set Spotify/Youtube inside the tab at.

I also installed firefox to check and it's reporting null... I checked with d-feet and while Volume is listed, it's not returning any value for Volume, only the Properties listed with a value below work: image

Moon-0xff commented 1 year ago

Then it's good, but I'm afraid some rogue application reports muted when it shouldn't. Please test and review latest commit, and be mindful of your whitespace!

Batwam commented 1 year ago

sorry for the rough formatting, it was just a quick test I was doing to see if removing muted sources would work. On the plus side, I finally found the option to "Render Whitespaces" in the IDE, that should help!

Based on the issues encountered (no visibility of volume within tabs, firefox not reporting volume,...), I think that we should scrap the idea of filtering muted sources and simply revert back to e753801. Since information from sources is inconsistent, it will look like the extension doesn't work properly and reflect negatively on the extension for what is actually an issue with the sources.

Moon-0xff commented 1 year ago

Yes, you are right. It's not a bad addition though. Maybe it could be added back in the future. Specially if firefox and chromium begin to correctly report their volume.

Moon-0xff commented 1 year ago

Hopefully i reverted the changes correctly and the extension is in good shape. If that's the case, and with your approval, I'm going to merge it.

Batwam commented 1 year ago

No problem with the latest commit. I don't think that you need my approval to merge but if you do, you have my blessing 😉

Moon-0xff commented 1 year ago

As reassurance, you are certainly good at detecting my mistakes.

Batwam commented 1 year ago

No worries, it's always much easier to spot other people's mistakes! Thanks for your patience fixing mine and showing better ways to integrate the changes into the code, it's a great learning opportunity 🙂

Moon-0xff commented 1 year ago

Well, thanks to you for submitting the PR in the first place. And for all the help. code and ideas you contribute it along the way.

Before merging this i want to discuss and hear your ideas for the next release, as there's still a lot that could be improved/added. But we are delaying the merge too much already. What about you open it as an issue? Or a pull request if you have some code for it.