Moon-0xff / gnome-mpris-label

A music related GNOME extension.
GNU General Public License v3.0
51 stars 10 forks source link

Update Controls Preferences Panel #40

Closed Batwam closed 1 year ago

Batwam commented 1 year ago

See proposed cosmetic updates to the Preferences panel:

image

Moon-0xff commented 1 year ago

I'm not sure about the subcategory names, "click" sounds strange and maybe dropping the "mouse" in "mouse scroll" would be better.

Batwam commented 1 year ago

Yeah, I don't know. It may sound obvious to us know but I think as especially since these features are somewhat hidden, it probably doesn't hurt to make it as clear as possible.

The word "click" is used for the first left/middle/right. We could change from "click" to "button" but we should change the descriptions for the first 3 items to accordingly for consistency.

For scroll, we could replace "Mouse scroll" with "Scroll wheel" otherwise?

Moon-0xff commented 1 year ago

Well, for me it doesn't trigger a sense of inconsistency, "Mouse click bindings" reads weird, but "Left/Right click" doesn't.
You can change the first 3 items for consistency if you think it would be better, I don't have an opinion on that.

About the scroll name, it comes from the fact that a mouse wheel isn't the only "thing" that can activate the bindings (same thing with the mouse buttons though, but most peripherals don't have more than two/three buttons), but i don't have a problem with that name.

Batwam commented 1 year ago

So the headings would be "Mouse bindings" for buttons and "Scroll bindings" for the wheel? I guess removing "Mouse" makes sense as not everyone will have a mouse, could be trackpad but then shouldn't the first category read "Button bindings"?

Moon-0xff commented 1 year ago

Closing this and adding the first commit separately.