search

Moon-0xff / gnome-mpris-label

A music related GNOME extension.
GNU General Public License v3.0
50 stars 10 forks source link

Mitigation for pref window crashes #41

Closed Moon-0xff closed 1 year ago

Moon-0xff commented 1 year ago

As mentioned in issue #36 the pref window crashes when changing settings rapidly, this isn't an issue with most preferences except the ones that require typing.

Batwam commented 1 year ago

So the idea is to only update on 'focus-out-event' when the user clicks away from the field rather than on every keystroke right?

By the way, is there a way to get a list of all the 'connect' events for a given widget?

Moon-0xff commented 1 year ago

The idea is to not update every keystroke because it can lead to crashes.

And I haven't tried to introspect an object to check for signals but surely it's possible. The documentation has a section of Signals for every object so it shouldn't be a mystery.

Batwam commented 1 year ago

Yeah, I didn't know it was possible but figured that might have been what it was doing based on the name. If that's the case that's great. In a way it's similar to the issue we discussed the other day regarding Player filtering and Shortwave.

We might need to do the same when implementing filtering although I quite like being able to see the label update as I type as it gives immediate feedback 🙂

For the events list, I was just wondering how you found out about this one as I was trying to find the equivalent of 'clicked' for a label the other day.