Moon-0xff / gnome-mpris-label

A music related GNOME extension.
GNU General Public License v3.0
51 stars 10 forks source link

Todo List - Contributions needed #4

Closed Batwam closed 1 year ago

Batwam commented 1 year ago

It's me again!

Features list for discussion (original list):

My thoughts:

  1. Interesting idea, I wonder if there is an automated way to locate/load these icons in gjs. It would be possible to include icon for the usual apps (rhythmbox, spotify, firefox, chromium,...) which would probably easier but I'm not sure if copyrights would allow it and there is a risk the icon shipped may not match the one used in the distro... there may be some content in the Vitals or runcat github repo which could be reused to load icons next to the text as they both have that.
  2. Could work. Alternatively, a drop down (or equivalent) with common apps might work too.
  3. In terms of implementation, there may be some code to be taken from the Vitals extension as it allows to chose content based on a menu activated when clicking the extension: https://github.com/corecoding/Vitals
  4. it might get confusing if clicking shows the menu in some cases but pauses in other cases? Including these controls within a menu might be better, something similar to this other discontinued mpris extension
  5. I agree that the current implementation which continuously updates is somewhat suboptimal but I don't know if this is even possibly. If it was, I wonder how much this would really save in terms of resource.

Features list for discussion (later additions):

Batwam commented 1 year ago

ok, I managed to find how to control the global volume from the extension and have implemented an option for Source/Global/Off in the Settings. It's working except for Chrome for "active source control" which returns changing mpris volume values just fine and looks like it's working find except that it doesn't actually affect the actual volume, it does nothing...

See #26 for details.

Moon-0xff commented 1 year ago

Closing this. All features of the original list were merged, and even the ones that we discussed later (except #31).
Some discussed features didn't even make it to the list. Some of them might be useful to revisit.

For now, let's focus in fixing the issues and merging #39. We can discuss things later.