Libadwaita update

[Batwam]

Hello,

I have updated the Preferences window to be more aligned to the GTK4 design of apps like gnome-settings using ActionRow and PreferencesGroup. Other changes may be made in the future (use sliders, ...) but for now, I focused on this single design update and maintained the original look to avoid creating too many changes at once.

before:

after:

[Batwam]

I'd also like to discuss some further related tweaks which cross my mind as I was working on this. For example:

1. in gnome-settings for example, row descriptions don't have : at the end. Please confirm we can remove those here too.

2. it doesn't look like tooltips are a thing in GTK4, apparently for accessibility reasons. I have used ActionRow subtitles as it's standard in apps like gnome-settings unless the text was too long to fit on a single line. For longer text, I automatically add an info button (popover) and put the entire text in it. Again, this is consistent with the look and feel of gnome-settings (I took inspiration from the Mouse section)

3. we could potentially have a reset button for each spinbutton/switch which would make the interface busier but allow to only reset individual settings and remove the need for the button at the bottom. I rarely use the reset button as it resets too many settings at once for my liking. Something like this which is used in the burn-my-windows extension: Or we keep the button but also include a button to reset each setting. Anyway, just and idea for now.

4. Use a ToggleButton like this for Left/Center/Right rather than drop downs

The third and fourth ones could be separate PRs if required.

[Moon-0xff]

Hello @Batwam!

I'm very pleased with the changes so far, although I will need to inspect them more closely.

As discussed in #67, or at least the conclusion I get from it is that we should align with GNOME design, but not be afraid of breaking that style if it fits us.

With that in mind, I agree with point 1 and 2.

I also agree to add an individual 'reset button' for each setting and to replace the drop-downs. As a separate PR.

I noticed the filters settings has barely changed and it might be better if the changes to it are recorded in another PR, unless the changes are easy to add.

[Batwam]

That sounds good. I consider that the update is complete so I'll just issue a final commit to remove the various : and that should be ready for review.

For the Filters page, I haven't really seen examples with entry fields spanning across the full width so I went light touch on it and mostly kept with the original design although I did create groups and a new function to generate the entry fields.

I have made a solid start on the individual reset buttons which I can share as a new PR once this is done. I might need some help for the combobox however.

[Moon-0xff]

As a side note, I tested if using 950 as the default height was problematic with an smaller screen. I down-scaled my monitor to 1280x720 and the window cuts off when it touches the screen border, so no problems there.

[Moon-0xff]

I noticed just a few problems:

• Wide entries don't align with the adwaita style (as mentioned)
• At minimum window size the triple combo box looks wrong
• Some repeated lines of code that probably we can skip

I don't have any problems to merge this to main as it stands. The flaws are minor and better to be worked in other(s) PR(s).

The only change I'll request is to remove the tab on line 20. But it's such a small thing I think I'll push with the --author option. Be ready to be impersonated!