Bluetooth audio receiving via a2dp on esp32

MoonModules / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi! MoonModules adds features on top of upstream.

https://mm.kno.wled.ge

GNU General Public License v3.0

187 stars 54 forks source link

Bluetooth audio receiving via a2dp on esp32 #107

Closed tonyxforce closed 5 months ago

softhack007 commented 5 months ago

Wow, that's a mega huge PR 😅 will need some time for reviewing....

A few questions upfront:

is is strictly necessary to put the complete ESP32-A2DP project into the "lib" folder? Can you use a github reference instead, and describe in your usermod readme how to add this tolib_deps?
why did you make changes to other usermods? Is this strictly needed for making your new usermod work?

Due to the large amount of changes in this PR, it may take time until we manage to review everything. So please be patient.

softhack007 commented 5 months ago

Hi @tonyxforce, I'm closing this PR because it looks to me that you opened it by mistake.

The idea is interesting, but you have a long way ahead of you to get this working. I also have some doubts that the concept of running everything - a bluetooth a2dp decoder, wifi, webserver, and WLED effects - on one MCU will work at all. It might just be too much workload for a single esp board.

Maybe the smarter solution will be to use two boards: 1) one board running WLEDMM with standard audioreactive 2) a second board running the bluetooth a2dp part, which sends UDP sound sync packets to the board running WLEDMM

cheers, Frank

tonyxforce commented 5 months ago

I've tested this code without WLED and it worked perfectly with an empty loop i'm currently just trying my best to merge WLED an this code

About the package installation tip, can you give me some more specific tips about how could i do that?

tonyxforce commented 5 months ago

The reason of the so many commits and the changes in other files is that i originally intended my repo to be completely separated from wled and delete everything from it i didn't personally need in my specific hardware and halfway through my coding i realized WLED could benefit if i made it a usermod so i put everything back and started working on it after i created this pull request

softhack007 commented 5 months ago

About the package installation tip, can you give me some more specific tips about how could i do that?

It's very simple to use a library from another repo on github. You just add it to lib_deps in you custom platformio build environment. Similar to this

https://github.com/MoonModules/WLED/blob/f7df60932ab67c8f42a480ce4c6e8a40965355cc/platformio.ini#L308-L315

The format is

user/repo @ release (makuna/NeoPixelBus @ ^2.7.5)
fullURL.git # branch (https://github.com/softhack007/LITTLEFS-threadsafe.git#master) However the first format is generally preferred, because it links to a specific release so the build will still work in a few years.

tonyxforce commented 5 months ago

Oh thanks! I didn't know you can do that with pio! Tomorrow i'll fix the issues and maybe recreate(delete/create new) repository for it to be a fresh start