MoonModules / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi! MoonModules adds features on top of upstream.
https://mm.kno.wled.ge
GNU General Public License v3.0
202 stars 64 forks source link

Rotary (alt): effects skipped when no speed/intensity slider exists #25

Open softhack007 opened 1 year ago

softhack007 commented 1 year ago

What happened?

Some effects (example, Hiphotic) seem to not allow editing of "Effect Speed" and "Effect Intensity" - they are just skipped over I'm guessing it's due to these lines:

case  1: if (!extractModeSlider(effectCurrent, 0, lineBuffer, 63)) newState++; else changedState = true; break; // speed
case  2: if (!extractModeSlider(effectCurrent, 1, lineBuffer, 63)) newState++; else changedState = true; break; // intensity

Thanks to Troy for reporting this problem. It seems to also happen like this in upstream

Install Method

Self-Compiled or other

What version/release of MM WLED?

2303150

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

Code of Conduct