search

MoonModules / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi! MoonModules adds features on top of upstream.
https://mm.kno.wled.ge
GNU General Public License v3.0
202 stars 64 forks source link

2D effects shown despite only 1D strip configured #27

Closed gradius-v closed 1 year ago

gradius-v commented 1 year ago

What happened?

The effects list shows 2D effects, but only a 1D strip is configured.

To Reproduce Bug

Configure a 1D strip.

Expected Behavior

Only 1D effects are shown.

Install Method

From https://wled-install.github.io/

What version/release of MM WLED?

WLEDMM_0.14.0-b2.20_esp32_4MB_M.bin (build 2303260)

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

No response

Code of Conduct

dosipod commented 1 year ago

Yes seems so . effects list shows 2D effects in 1D and they are on solid color without animation . [edit same with AC main]

MoonModules commented 1 year ago

Agree with expected behaviour.

Can you test in latest AC main, I just did and also see 2D effects there in 1D setup... so something changed in AC main?

MoonModules commented 1 year ago
image

I suspect this code which has been recently updated in AC main for 0D support.

The remove('hide') in particular

@blazoncek, could that cause showing of 2D effects in 1D mode?

dosipod commented 1 year ago

Yes , updated to latest AC main and we see the same behavior.

blazoncek commented 1 year ago

Fixed locally. Will be upstream after a while.