Audio sync receive only - EPS8266

MoonModules / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi! MoonModules adds features on top of upstream.

https://mm.kno.wled.ge

GNU General Public License v3.0

202 stars 64 forks source link

Audio sync receive only - EPS8266 #60

Closed netmindz closed 1 year ago

netmindz commented 1 year ago

Option to have ESP8266 listen for AudioReactive data from an ESP32

netmindz commented 1 year ago

Issue with soundAgc , autoResetPeak maxVol, binNum & FFT_MajPeakSmth

softhack007 commented 1 year ago

Issue with soundAgc , autoResetPeak maxVol, binNum & FFT_MajPeakSmth

soundAgc: can be kept as "0", because AGC is done by the sender.
FFT_MajPeakSmth: not transmitted yet, but you can use FFT_MajorPeak as replacement
soundPressure: use volumeSmth as replacement
agcSensitivity: can be replaced by "1" (not transmitted by udp)
maxVol, binNum: these vars are fed back from some effects to configure the peak detector. You can ignore them (ie replace with local vars that have default values).
autoResetPeak: needed to reset the "peak indicator". I'll think of a replacement function - you don't have FFTTask on 8266, but it's just important to regularly call peak reset, timing is not critical.

softhack007 commented 1 year ago

I can provide more feedback in the next days

Thanks for the good work, it looks like we are very close already 🥇

netmindz commented 1 year ago

Think that's all the changes bar the autoResetPeak one

blazoncek commented 1 year ago

I know you all hate me for my "strict selection criteria" (or plain old bluntness) but I think this PR should be done upstream. Everyone benefits that way.

Please.

dosipod commented 1 year ago

Same was reported before about ui being highly unstable and hence we could not even test it , now i see all kind of errors

softhack007 commented 1 year ago

special cases that should be tested:

Peak detector (samplePeak) - visible in effects, and properly reset (i.e. not stuck-at 1)
receiving from a "v1" (SR 0.13.4) sender: AGC on, AGC off.

softhack007 commented 1 year ago

Peak detector (samplePeak) - visible in effects, and properly reset (i.e. not stuck-at 1)

Update: tested and works, including autoResetPeak() 👍

receiving from a "v1" (SR 0.13.4) sender: AGC on, AGC off.

still to be tested.

netmindz commented 1 year ago

I know you all hate me for my "strict selection criteria" (or plain old bluntness) but I think this PR should be done upstream. Everyone benefits that way.

Please.

Not easily possible due to significant divergence of the AR module, something I was working to reduce by at least syncing the extra drivers back upstream. The downstream change to i2c broke mm so had to revert that till I have time to see what went wrong there

netmindz commented 1 year ago

receiving from a "v1" (SR 0.13.4) sender: AGC on, AGC off.

still to be tested.

Do you have suitable setup to test this @dosipod ?

dosipod commented 1 year ago

receiving from a "v1" (SR 0.13.4) sender: AGC on, AGC off.

still to be tested.

Do you have suitable setup to test this @dosipod ?

@netmindz sure we are already testing that on two units for last hour or so and it is fine , the issues we faced before was not related to audio sync and was fixed by @softhack007