search

MoonModules / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi! MoonModules adds features on top of upstream.
https://mm.kno.wled.ge
GNU General Public License v3.0
202 stars 64 forks source link

Fix return value (frameDelay) of FX_MODE_STATIC #73

Closed arneboe closed 11 months ago

arneboe commented 1 year ago

FX_MODE_STATIC used a hard coded return value of 350. This causes visible lag/stuttering when updating the strip brightness via artnet/dmx.

This PR returns FRAMETIME instead of 350 to fix that.

ewowi commented 1 year ago

Frametime normally around 25 (40fps), so this will make solid use more cpu but who cares ;-)

Propose to combine this with https://github.com/MoonModules/WLED/issues/72

softhack007 commented 11 months ago

Frametime normally around 25 (40fps), so this will make solid use more cpu but who cares ;-)

@ewowi frametime can be much shorter, especially with FASTPATH (down to 3ms = 250fps). The objective of the PR seems to make changes to solid colour look "smooth", so it might be good enough to return(25);, or maybe return(30);.

In MM we could usereturn(FRAMETIME_FIXED_SLOW); as this was intended as being "low cpu but still smooth".

softhack007 commented 11 months ago

done. will merge now.