search

MoonModules / WLED

Control WS2812B and many more types of digital RGB LEDs with an ESP8266 or ESP32 over WiFi! MoonModules adds features on top of upstream.
https://mm.kno.wled.ge
GNU General Public License v3.0
202 stars 64 forks source link

Animartrix effects: weird colors in some effects #82

Closed FragMenthor closed 11 months ago

FragMenthor commented 11 months ago

What happened?

Some effects give me colors that do not match the rest of the effect. Nomally is a solid green color that is superimposed on the effect, like some limit has been reached. Namelly:

To Reproduce Bug

Don't know if anyone more has this problem, but is shows for me in the UI and it reflects on the LEDs. This shows for me like this since the initial implementation of Animartrix in WLED, and no matter what version I use (_M _S, custom, ...) No change with any version, and I update almost weekly in my test setup with 'mdev'.

Expected Behavior

Smooth and continuous effects, they change abruptly using solid colors, and seem broken somehow.

Install Method

Self-Compiled or other

What version/release of MM WLED?

WLEDMM_0.14.0-b27.32 esp32_4MB_M.bin build 2310081

Which microcontroller/board are you seeing the problem on?

ESP32

Relevant log/trace output

No response

Anything else?

I don't think this is the expected normal behaviour. If this is intentional, the please close the issue. Thank you!

Code of Conduct

dosipod commented 11 months ago

The weird colors has been noticed and reported since the initial implementation of Animartrix .as palette is not used we thought that it is still WIP . You have described it better then we did

FragMenthor commented 11 months ago

What is the possibility of adding pallettes to these effects?

dosipod commented 11 months ago

@netmindz could say as he is the one who ported the Animartrix

netmindz commented 11 months ago

So it doesn't really make sense to use a palette due to the way the effects are designed so I don't see Stefan ever adding that to his code.

There are a few bugs where the colours don't reset properly when you move to certain effects.

Due to the lack of a gamma correction a few don't work in quite the same way as on Smart matrix.

As for blocks of colour with no fade, I've not seen this behaviour

dosipod commented 11 months ago

This FX192 Water example , it is really very good as i recall i seen it from Stefan , other then the strange superimposed color which spoils it , thank you for the work though i do hope it could be improved even if as a future plan since you already did the hard part 192_water

netmindz commented 11 months ago

This fix should certainly help https://github.com/netmindz/animartrix/commit/8fd0df3e0b006244d53eaf480c2720daa5a697aa

Pulled in with https://github.com/MoonModules/WLED/pull/83

dosipod commented 11 months ago

I have tried to experiment and change all the values under led preference ,Buffer , Gamma ,FPS ..etc but it is worth noting that the issue is not with all effects but only few of them ( e.g waves seems perfect) ., the one listed by the OP is somewhat still the same , FX192 Water is also still the same .
192_water_v2

netmindz commented 11 months ago

Please test the patterns and report any bugs with them against

https://github.com/netmindz/animartrix/tree/OO

WLED just wraps this library. When I raised the issue of the colours of Water Stefan said it related to fact it was designed for SmartMatrix which has gamma correction

netmindz commented 11 months ago

Quick (untested) attempt at adding gamma correction https://github.com/MoonModules/WLED/pull/85

netmindz commented 11 months ago

Found what's wrong with water - the red is going negative and so flipping to full brightness

netmindz commented 11 months ago

Next daily build has fixed version of rgb_sanity_check

netmindz commented 11 months ago

Should all now be resolved I think @FragMenthor if you try this build https://github.com/MoonModules/WLED/actions/runs/6599717911 (scroll to the bottom for the assets)

FragMenthor commented 11 months ago

Should all now be resolved I think @FragMenthor if you try this build https://github.com/MoonModules/WLED/actions/runs/6599717911 (scroll to the bottom for the assets)

Thanks!!! I will try tomorrow as soon as I can! 😀

dosipod commented 11 months ago

Yeah i have tested all the effects and no more superimposed color so issue is fixed

FragMenthor commented 11 months ago

Should all now be resolved I think @FragMenthor if you try this build https://github.com/MoonModules/WLED/actions/runs/6599717911 (scroll to the bottom for the assets)

Thanks!!! I will try tomorrow as soon as I can! 😀

Should all now be resolved I think @FragMenthor if you try this build https://github.com/MoonModules/WLED/actions/runs/6599717911 (scroll to the bottom for the assets)

Thank you! All effects seem OK now! Great job! 👍 💯