Closed wholmgren closed 8 years ago
There are a couple of pep8 issues. The most important ones to me are:
forecast.py
calcWind, addRadiation
<
+
Half --> half, Quarter --> quarter
Here is the link to the pvlib variable name guide:
https://github.com/pvlib/pvlib-python/wiki/Variables-and-style-rules
For consistency with the rest of pvlib, I'd like to use:
latitude
longitude
latlon
ghi
downward_shortwave_radflux
dni_extra
sp0
All of these issues I have addressed. Unless you see any other issues I am considering this done for now.
There are a couple of pep8 issues. The most important ones to me are:
forecast.py
offenders:calcWind, addRadiation
<
), between operators (+
)Half --> half, Quarter --> quarter
.Here is the link to the pvlib variable name guide:
https://github.com/pvlib/pvlib-python/wiki/Variables-and-style-rules
For consistency with the rest of pvlib, I'd like to use:
latitude
andlongitude
instead oflatlon
ghi
instead ofdownward_shortwave_radflux
dni_extra
instead ofsp0
.