test_forecast - Githubissues

MoonRaker / pvlib-python

A set of documented functions for simulating the performance of photovoltaic energy systems.

BSD 3-Clause "New" or "Revised" License

0 stars 0 forks source link

Closed wholmgren closed 8 years ago

wholmgren commented 8 years ago

Some notes on test_forecast.py...

[ ] test_fmcreation has a clever inspect.getmembers(forecast,inspect.isclass) call. Might be a little too clever? Not sure what the advantage of the _model_list of strings is over a list of classes.
[ ] test_data_query: why are we allowing the exception? In case a model is not available? Maybe just a comment is needed.
[ ] test_vert_level: while not a problem to have here, I'm just wondering what the use of this is.

wholmgren commented 8 years ago

Comprehensive tests are a high priority!

MoonRaker commented 8 years ago

Yes, it should have been... now it is.

MoonRaker commented 8 years ago

All tests are now written and covers all the code. This includes the latest and hopefully most of the main updates at least for now.