MoonRaker / pvlib-python

A set of documented functions for simulating the performance of photovoltaic energy systems.
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

test_forecasting.py #2

Closed wholmgren closed 8 years ago

wholmgren commented 8 years ago

We need a pvlib/test/test_forecasting.py module that performs automated tests of forecasting.py.

wholmgren commented 8 years ago

Also, what's your plan for pvlib/forecast_testing.py? It seems to me that it might be the start of both the automated testing and a documentation page with inline figures, but it the file itself needs to go since it doesn't fit in the structure.

MoonRaker commented 8 years ago

That sounds good. I left it in because I hadn't decided which direction to go but I think we covered this in Issue #3.

MoonRaker commented 8 years ago

I have converted the forecast_testing.py file to an jupyter/ipython notebook and also created scripts for from all of the notebooks as well.

wholmgren commented 8 years ago

We still need a module in pvlib/test that is named test_forecasting.py that performs automated unit tests of forecasting.py and that can be run by nose, just the same as every other module in pvlib. The notebooks are not the same thing as unit tests. Maybe look at the other modules in pvlib/test as an example.

I will need to review the converted scripts in more detail before I can comment on whether or not I think that's something that we should integrate into the documentation. One thing that I can say now though is that I don't think that we should ask people to create custom profiles just so that they can run the notebooks since that's not user friendly.

MoonRaker commented 8 years ago

I will work on the automated test script for forecast.py.

What do you mean by custom profiles?

MoonRaker commented 8 years ago

This file longer exists and has been split into several Jupyter/Ipython notebooks.