search

MoonSHRD / UniversalNFTMarketplace

Universal NFT Marketplace
Other
9 stars 0 forks source link

Feat/marketplace #77

Closed JackBekket closed 3 years ago

JackBekket commented 3 years ago

fixed small bug in TokenSaleSingleton

started to work at secondary market (MetaMarketplace.sol) work isn't finished yet

todo[bot] commented 3 years ago

wrong calculation, need to fix.. use IERC721Enumarable interface for MSNFT

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/cbf6f90f28baa56079ca5f09564cc06e3f9c98c8/contracts/721/singleton/InterfaceRegister.sol#L47-L52

This comment was generated by todo based on a TODO comment in cbf6f90f28baa56079ca5f09564cc06e3f9c98c8 in #77. cc @MoonSHRD.
todo[bot] commented 3 years ago

add func to upd sale_template when we upgrade version

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/cbf6f90f28baa56079ca5f09564cc06e3f9c98c8/contracts/721/singleton/MasterFactory721.sol#L26-L29

This comment was generated by todo based on a TODO comment in cbf6f90f28baa56079ca5f09564cc06e3f9c98c8 in #77. cc @MoonSHRD.
todo[bot] commented 3 years ago

are we want to withdraw offer at all, or we want to withdraw offer in specific currency (?)

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/cbf6f90f28baa56079ca5f09564cc06e3f9c98c8/contracts/721/singleton/MetaMarketplace.sol#L160-L165

This comment was generated by todo based on a TODO comment in cbf6f90f28baa56079ca5f09564cc06e3f9c98c8 in #77. cc @MoonSHRD.
todo[bot] commented 3 years ago

add decreasing escrow (limit?)

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/cbf6f90f28baa56079ca5f09564cc06e3f9c98c8/contracts/721/singleton/MetaMarketplace.sol#L232-L237

This comment was generated by todo based on a TODO comment in cbf6f90f28baa56079ca5f09564cc06e3f9c98c8 in #77. cc @MoonSHRD.
todo[bot] commented 3 years ago

add requirement for buyers to have enough approved money for every auction

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/cbf6f90f28baa56079ca5f09564cc06e3f9c98c8/contracts/721/singleton/MetaMarketplace.sol#L313-L318

This comment was generated by todo based on a todo comment in cbf6f90f28baa56079ca5f09564cc06e3f9c98c8 in #77. cc @MoonSHRD.
todo[bot] commented 3 years ago

check for erc20 approval here required (global approvment check)

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/cbf6f90f28baa56079ca5f09564cc06e3f9c98c8/contracts/721/singleton/MetaMarketplace.sol#L321-L326

This comment was generated by todo based on a TODO comment in cbf6f90f28baa56079ca5f09564cc06e3f9c98c8 in #77. cc @MoonSHRD.
todo[bot] commented 3 years ago

we don't lock funds, we only check approve, so there are no need to escrow funds, transferFrom, refund, etc.. We can remove all of next

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/cbf6f90f28baa56079ca5f09564cc06e3f9c98c8/contracts/721/singleton/MetaMarketplace.sol#L339-L344

This comment was generated by todo based on a TODO comment in cbf6f90f28baa56079ca5f09564cc06e3f9c98c8 in #77. cc @MoonSHRD.
todo[bot] commented 3 years ago

remove it(?)

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/cbf6f90f28baa56079ca5f09564cc06e3f9c98c8/contracts/721/singleton/MetaMarketplace.sol#L358-L363

This comment was generated by todo based on a TODO comment in cbf6f90f28baa56079ca5f09564cc06e3f9c98c8 in #77. cc @MoonSHRD.
todo[bot] commented 3 years ago

check this and probably add marketplaceSetted check

https://github.com/MoonSHRD/UniversalNFTMarketplace/blob/cbf6f90f28baa56079ca5f09564cc06e3f9c98c8/contracts/721/singleton/MetaMarketplace.sol#L452-L457

This comment was generated by todo based on a TODO comment in cbf6f90f28baa56079ca5f09564cc06e3f9c98c8 in #77. cc @MoonSHRD.