Moonbase59 / loudgain

ReplayGain 2.0 loudness normalizer based on the EBU R128/ITU BS.1770 standard (-18 LUFS, FLAC, Ogg, MP2, MP3, MP4, M4A, AAC, ALAC, Opus, ASF, WMA, WAV, AIFF, WavPack, APE)
Other
190 stars 23 forks source link

Reminder: Add real case insensitivity to loudgain’s RG tag removal code. #10

Closed Moonbase59 closed 5 years ago

Moonbase59 commented 5 years ago

This is mainly a reminder to myself:

For tag formats that support having "the same" tag in different case variations, loudgain currently checks for both (pure) lower- and uppercase variants and removes these before writing new tags. This should be changed to real case insensitivity since some taggers might write mixed-case tags (ReplayGain_Track_Gain).

We can run into curious situations otherwise: Tagger A writes lowercase, tagger B writes uppercase, tagger C writes mixed case. Player A only reads lowercase, player B reads only uppercase. If values are different, the user might get surprising loudness variations and never know why.

So loudgain should remove all variations of the ReplayGain tags and rewrite in the case specified on the commandline (-L option).