Moonlight-Panel / Moonlight

The next generation hosting panel
https://moonlightpanel.xyz
Creative Commons Zero v1.0 Universal
285 stars 31 forks source link

V2 add image update #424

Open Moritz-Deiaco opened 3 months ago

Moritz-Deiaco commented 3 months ago

The Update Feature is doing:

Masu-Baumgartner commented 3 months ago

And use FirstOrDefault instead of Any + FindIndex. This reduces the db calls. If the item is missing the return value would be null

Moritz-Deiaco commented 3 months ago

The FindIndex and Any are called on a local list instead of the db

Moritz-Deiaco commented 3 months ago

So it would not really make a difference

Masu-Baumgartner commented 3 months ago

Another thing is that all server using the image need to have their variables updated too as they would stop working if the image varaibles get updated

Moritz-Deiaco commented 3 months ago

Oh, i didnt thought about that, i will do that later/tomorrow

Masu-Baumgartner commented 3 months ago

Oki. Thx for the help with moonlight. Take your time ^^