Feature/typing improvement

Moonlight-io / asteroid-sdk-js

5 stars 3 forks source link

Closed rockacola closed 4 years ago

rockacola commented 4 years ago

Few non-breaking change typing improvement against latest implementation in develop branch

rockacola commented 4 years ago

@lllwvlvwlll I think these changes are straight forward, but would be perfect if you can eye over the changes in case I missed the obvious:

Add a new RootKeyItem interface
Add a new EncryptionMethod type
- It should further compliment inverseClaimEncryptionModes constant in the near future
Review some of the response type in neo-contract-identity.ts
- Change some from Promise<any> to Promise<void>
No changes to null usages in this PR, so in theory it should have no impact to CI

rockacola commented 4 years ago

@lllwvlvwlll reminder to review PR when you get a chance.