search

Moonlight-io / asteroid-sdk-js

5 stars 3 forks source link

Attribute validator incorrectly invalid avatar attribute from editing #80

Closed rockacola closed 4 years ago

rockacola commented 4 years ago

As object property will not be supplied when editing.

rockacola commented 4 years ago

Blocks https://github.com/Moonlight-io/vega/issues/614

rockacola commented 4 years ago

By making object nullable, this means 'empty check' will currently required to be done on the client side, as a SDK no longer provide validation check on that part.

rockacola commented 4 years ago

@lllwvlvwlll

I originally intend to make the object property to allow undefined (as per purpose of 0.16.1 release). But that doesn't work as ADU will silently failed when object property is not presented. The next best thing to do will be to cater empty object property in vega, which will mitigate concern https://github.com/Moonlight-io/vega/issues/614 while ADU remains unchanged.

rockacola commented 4 years ago

Finalized changes per 0.16.2