search

MoonlitOwen / ChocolateSans

朱古力黑體 Chocolate Classical Sans
Other
20 stars 1 forks source link

Updating build system for GF #5

Closed aaronbell closed 5 months ago

aaronbell commented 5 months ago

Updated the repository to build using GF's standard builder tool. Also updated font data to address FB issues.

hfhchan commented 5 months ago

The thing is, the original author doesn't have glyphs, so whenever he makes a change and re-export the UFO from the .fcp file he is using, all of the changes made to the .UFO files will be overwritten.

Any changes made to the .UFO font files needs to be done as part of the build phase and shouldn't be committed back to the repository.

aaronbell commented 5 months ago

Can't he re-import the UFO back into Font Creator and then continue work from there? Otherwise the .UFO is not acting as a true source in this case but an interim build step.

laubonghaudoi commented 5 months ago

@aaronbell As far as I know, the original font creator doesn't have source files at all. He created the font by directly editing the .otf file. So the .otf is the only source. Even the .ufo files are later exported from the otf.

MoonlitOwen commented 5 months ago

I'm sorry, but to be honest I don't understand what this change is, also I have no idea what you are talking about. ^^;;;;;;; When I create/edit fonts, I open the otf or ttf file directly, edit the font in the font editing software (like FontCreator or FontForge), and then output it back to otf or ttf file. If I want to create new fonts, or want to edit the previous font files, I do it in the font editing software directly. I've already output the "ufo files" in the font software and upload them on github according to your request before. I will continue to use my font software to output otf or ttf when I modify the fonts in the future, I don't want my right to create fonts to be restricted. I will output the "ufo files" again and upload them again evereytime I edit this font if you wish. I don't know if I can respond to you in this way? Thank you.

aaronbell commented 5 months ago

Thanks for the information. In discussing with my colleagues, it sounds like it would be best for us to maintain a separate fork of the font at this time with the source set up as a UFO. We'll let you know of any issues that we discover that we'd suggest fixing upstream, and can discuss if it makes sense to re-merge the repositories at a later point.

hfhchan commented 5 months ago

Can't he re-import the UFO back into Font Creator and then continue work from there?

Yes, but I am quite sure that Font Creator will output the same or similar non-standard UFO files in the end.

Otherwise the .UFO is not acting as a true source in this case but an interim build step.

Unfortunately the workflow that the original author is familiar with, and is able to operate, only involves Font Creator. The binary format of Font Creator is not open, so the compromise solution we could come up for him was to export the UFO every time he makes a change.

Since this font is based on Source Han Sans, and the development of Source Han Sans relies on proprietary software from Adobe, we're not able to use their workflow either.

Let me know if there are changes I can make on his behalf to make this easier to integrate downstream.