Update Apache Maven to 3.9.8

Moonshine-IDE / Moonshine-SDK-Installer

To take full advantage of Moonshine IDE you will need third party SDKs like Apache® Flex or Apache® Royale. In order to make it easier for you to setup the required SDKs, we created the Moonshine SDK Installer.

https://moonshine-ide.com/download-sdk-installer/

Other

8 stars 2 forks source link

Update Apache Maven to 3.9.8 #120

Open piotrzarzycki21 opened 2 weeks ago

piotrzarzycki21 commented 2 weeks ago

I've been started to experience problem locally with building our Royale applications using Maven 3.6.0 which is part of SDK Installer. All builds on GH Actions are working, because they are using newest version of Maven.

https://maven.apache.org/download.cgi

JoelProminic commented 2 weeks ago

If we update this, we'll want to go through and make sure all the project templates that use Maven can work with the newer version. See #99 for an example of the problems we had with Gradle.

Note that the Maven scripts are effectively broken on macOS for the Domino Visual Editor and Form Builder projects - this is an issue with the newer Notes client versions.

piotrzarzycki21 commented 2 weeks ago

This so far influence Royale application itself, but as well Royale framework as well. If I will have to work on some fix in Royale I will need that update. However note that I already upgrade my local Maven to that version, so I'm good with that, but this is something which we will have to have on our radar.

Additionally doesn't hurt us to have this update in development version of SDK Installer 4.7.0.

rat-moonshine commented 2 weeks ago

It's updated. Please give some tests, when a new build is available.

Were we shifted to build Development version with GHA? I don't see installer from https://static.moonshine-ide.com/downloads/msdki/dev/macos/ installs as "MoonshineSDKInstallerDevelopment" but "MoonshineSDKInstaller"!

piotrzarzycki21 commented 2 weeks ago

Thanks @rat-moonshine for update! @Aszusz it was for purpose to have this like that ?

piotrzarzycki21 commented 2 weeks ago

@rat-moonshine Installer installs as MoonshineSDKInstallerDevelopment on my system, so it's correct I believe.

piotrzarzycki21 commented 2 weeks ago

I was able to successfully install and setup Maven 3.9.8

rat-moonshine commented 2 weeks ago

@rat-moonshine Installer installs as MoonshineSDKInstallerDevelopment on my system, so it's correct I believe.

It turned out that I had a MoonshineSDKInstallerDeveloment.app exists somewhere in my local build directory. By macOS' nature, any new installation keep updating that executable only, instead of installing at /Applications. Once removed that exec, new installation installs in correct location.

JoelProminic commented 2 weeks ago

As I mentioned earlier, I'd like to do some tests with Maven 3.9.8 and the current Maven project templates so that we don't break those projects for new users.

Other things I'd like to check or discuss:

Will Moonshine automatically update to the newer version of Maven if it is installed? - UPDATE: No, it keeps the existing version. Do we need to change this, or are we fine with existing users updating manually
If the older version of Maven is installed, will MSKDI enable the install button for Maven? - UPDATE: Yes, I got the prompt to install the new version.