search

Moonshine-IDE / Moonshine-SDK-Installer

To take full advantage of Moonshine IDE you will need third party SDKs like Apache® Flex or Apache® Royale. In order to make it easier for you to setup the required SDKs, we created the Moonshine SDK Installer.
https://moonshine-ide.com/download-sdk-installer/
Other
8 stars 2 forks source link

Showing bulk license agreements during "Install Everything Now!" button #44

Closed rat-moonshine closed 3 years ago

rat-moonshine commented 3 years ago

This issue originally reported and discussed at here: https://github.com/prominic/Moonshine-SDK-Installer/issues/32#issuecomment-832982753 and https://github.com/prominic/Moonshine-SDK-Installer/issues/32#issuecomment-833276757.

rat-moonshine commented 3 years ago

(Sorry, for bit of a late update)

@JoelProminic I did some structural changes to the license view, and I think this is now ready for your test. This fix is part of #32 for better reason, so you want to download the branch builds.

Please, check.

JoelProminic commented 3 years ago

The new Tree interface looks good on macOS: image

If I open this when there are no SDKs to install, I still see the behavior from before. This is an edge case that doesn't have any practical use, though: image

rat-moonshine commented 3 years ago

Ouch! Although I thought about the scenario but I missed it (in implementation). I shall update.

rat-moonshine commented 3 years ago

Ouch! Although I thought about the scenario but I missed it (in implementation). I shall update.

The "Install Everything Button" should be disabled now in case of everything have downloaded.

I also tried to look into all the "http" download links in configuration and change them to "https". However, one link that didn't worked on "https" was Royale Nightly - http://apacheroyaleci2.westus2.cloudapp.azure.com:8080/job/royale-asjs_jsonly/lastSuccessfulBuild/artifact/out/apache-royale-0.9.8-bin-js.tar.gz. @piotrzarzycki21 do we have any chance to have the links available on "https"?

piotrzarzycki21 commented 3 years ago

I don't think I will be able to provide https link from that source. However I think we could try to think about switching to this link: https://nightlies.apache.org/Royale/Royale-asjs/ - Unfortunately today I have discovered that on Mac I'm getting error during build of MyAccount using 0.9.9-SNAPSHOT - You could try and check yourself whether you can build MyAccount using this link. Build which I'm providing is being prepared by Maven, not ANT as our current links. Additionally that link is part of Apache Foundation resources, so it will always work.

piotrzarzycki21 commented 3 years ago

@rat-moonshine Please switch link to 0.9.8 build - use above link which I have provided.

I need to resolve issue with 0.9.9 nightly - which causes that building MyAccount is failing on Mac - it is not related to our IDE.

rat-moonshine commented 3 years ago

Where I can find .tar.gz version (for macOS) following this URL - https://nightlies.apache.org/Royale/Royale-asjs/?

piotrzarzycki21 commented 3 years ago

Where I can find .tar.gz version (for macOS) following this URL - https://nightlies.apache.org/Royale/Royale-asjs/?

Ohh it should be tar.gz - is it standard Mac OS format ? zip is something which is not recognized default ?

rat-moonshine commented 3 years ago

We require .zip for Windows and .tar.gz on macOS. That is how all the download works including the stable Royale. Please provide both type links.

piotrzarzycki21 commented 3 years ago

If that is the case it looks like I need to investigate what to do in order to have file in that format, but there is possibility that it won't be possible, cause those archive may be prepared by some Apache Foundation mechanism. Can we stay than for now with older stuff downloaded from http links ?

rat-moonshine commented 3 years ago

Yeah sure, until they works. I'm not very confident on using zip on macOS as I seen some oddity in extraction process during Harman/Flex unzip, through Ant build process. It's better we continue to maintain .tar.gz version on macOS case.

piotrzarzycki21 commented 3 years ago

Ok I will see what I can do, but expecting to have stuff for next release.

JoelProminic commented 3 years ago

After I install Harman AIR in Moonshine, I see it does not update the total install size, so the INSTALL EVERYTHING button is still enabled. After a restart, this is updated an the button is disabled: image

On this Windows test VM, I don't have Notes installed. I see that it shows up in the total install space for MSDKI, but MSDKI can't install Notes currently. There are no download links or licenses, and I see this is "hanging" as well: image

If I click "I ACCEPT THE LICENSE..." from this prompt, nothing happens and the prompt does not close.

rat-moonshine commented 3 years ago

I see the calculation of install-everything-button wasn't happening post-downloads. This fixed now along with some additional adjustment to have the experience more correct. Please, check.

piotrzarzycki21 commented 3 years ago

We require .zip for Windows and .tar.gz on macOS. That is how all the download works including the stable Royale. Please provide both type links.

I think I have added support for that in Royale -> https://github.com/apache/royale-asjs/commit/ba55b7a3b6122a6c9b770555683a826322183a0d I will monitor build and see if it helps.

piotrzarzycki21 commented 3 years ago

Ok it worked .tar.gz is available, but we should stay for now with old links, cause 0.9.8 is not released yet, so 0.9.9 is temporary available probably.

JoelProminic commented 3 years ago

Since we update the download links for all the SDKs to use https://, we need to test all of the SDK installations at least once before release.

The Royale Nightly build updates should be moved to a separate issue in the next release.

JoelProminic commented 3 years ago

I moved the Royale Nightly discussion to #46.

I re-tested all the SDK downloads on macOS and Windows for the https:// update. Everything seemed to work fine.