Moonshine-IDE / Moonshine-SDK-Installer

To take full advantage of Moonshine IDE you will need third party SDKs like Apache® Flex or Apache® Royale. In order to make it easier for you to setup the required SDKs, we created the Moonshine SDK Installer.
https://moonshine-ide.com/download-sdk-installer/
Other
8 stars 2 forks source link

Cannot download anything with the Moonshine SDK Installer #71

Closed ciacob closed 2 years ago

ciacob commented 3 years ago

Cannot download anything with the Moonshine SDK Installer. Anything that I should know? On Windows 10 professional here. Screenshot 2021-09-30 213943

piotrzarzycki21 commented 3 years ago

Thanks for reporting @ciacob. @rat-moonshine please verify first why Default SDK Location is displaying null - different user reported me similar issue as above and I have also noticed null on his screenshot in SDK location.

piotrzarzycki21 commented 3 years ago

I have noticed on my Windows 10 Hope that I don't have button "change": msdki

Screenshot sent by user: image002

GIF 01-10-2021 17-24-59

Please test scenario where you change default location to any other on Windows as well.

rat-moonshine commented 3 years ago

Are you still seeing this? As I'm testing with production v4.0.0 (as of @ciacob ) I don't see the broken-link alert (which actually is after link-verification) on Windows. I can open both Apache and Harman AIR/Flex license agreement windows followed by downloads.

piotrzarzycki21 commented 3 years ago

Are you still seeing this? As I'm testing with production v4.0.0 (as of @ciacob ) I don't see the broken-link alert (which actually is after link-verification) on Windows. I can open both Apache and Harman AIR/Flex license agreement windows followed by downloads.

I got email 1 October from user and it's still relevant for her. I cannot reproduce issue with prompt on Windows, but maybe it's just me. I would like you to focuse on checking why Default SDK location is null - maybe we have there some problems at first. What's more on Mac there no information about default location at all - this may be on purpose.

rat-moonshine commented 3 years ago

There are multiple things in these queries.

  1. Unable to download Apache/Harman Flex/AIR SDK - the alert suppose to trigger when link-verifier somehow fails to check the download URL, this could be a reason of any network problem. I'm not having any problem with stable build, though
  2. "Change" button appears only on Windows where we don't have a necessity to download SDKs in a specific location (i.e. on macOS it's Downloads)
  3. The option to "Change" download location appears only when there is no SDK already being downloaded - that is like when you install MSDKI fresh - you can trigger the appearance by renaming your current "MoonshineSDKs" folder and restart
  4. Default SDK Location: null that is surely a bug, I'd suggest we create a relevant issue on that
piotrzarzycki21 commented 3 years ago

4. Default SDK Location: null that is surely a bug, I'd suggest we create a relevant issue on that

Done #72

piotrzarzycki21 commented 3 years ago

3. The option to "Change" download location appears only when there is no SDK already being downloaded - that is like when you install MSDKI fresh - you can trigger the appearance by renaming your current "MoonshineSDKs" folder and restart

I have on my list not downloaded SDKS - for example Gradle, Grails - If I have such I should see that button ?

rat-moonshine commented 3 years ago

It's basically if it sees that the MSDKI default location "C:/MoonshineSDKs" being created (creates during a download) - it assumes the default-location already being set and not provides the location change option thereafter.

rat-moonshine commented 2 years ago

I have removed this from v4.1.0 milestone. If we can't reproduce I'll suggest close this.

piotrzarzycki21 commented 2 years ago

Client which has similar issue and reported me this separately tested downloading SDK with newest nightly build and she have same issue. I have discovered that she is using different language in her Windows - Spanish. @rat-moonshine if you have time could you try on your virtual machine with windows whether changing language for a whole system does trigger that issue.

rat-moonshine commented 2 years ago

Ah! Okay.

But I'm unclear at this moment what could cause related to language during a link-verification in MSDKI, as I don't see any message parsing (following a NativeProcess run) in link-verification. I can give this a more proper test when I shall be back again.

piotrzarzycki21 commented 2 years ago

I don't know either, but this is the only lead so far which I have. If not I will thing how to debug that on her sight...

piotrzarzycki21 commented 2 years ago

@rat-moonshine What is your logic to check those url, since they are failing ?

rat-moonshine commented 2 years ago

@rat-moonshine What is your logic to check those url, since they are failing ?

https://github.com/Moonshine-IDE/Moonshine-SDK-Installer/blob/master/MoonshineSDKInstaller/src/actionScripts/utils/LinkVerifier.as

Search for the usage with new LinkVerifier in this file - https://github.com/Moonshine-IDE/Moonshine-SDK-Installer/blob/master/MoonshineSDKInstaller/src/components/HelperInstaller.mxml.

piotrzarzycki21 commented 2 years ago

@rat-moonshine What is your logic to check those url, since they are failing ?

https://github.com/Moonshine-IDE/Moonshine-SDK-Installer/blob/master/MoonshineSDKInstaller/src/actionScripts/utils/LinkVerifier.as

Search for the usage with new LinkVerifier in this file - https://github.com/Moonshine-IDE/Moonshine-SDK-Installer/blob/master/MoonshineSDKInstaller/src/components/HelperInstaller.mxml.

By looking into your code it looks like you are getting NativeProcess exit https://github.com/Moonshine-IDE/Moonshine-SDK-Installer/blob/26522bc7798ac73acc34f7a3a5f0f73d62b3e17b/MoonshineSDKInstaller/src/actionScripts/utils/LinkVerifier.as#L104

If I would like to replicate your logic outside Moonshine what kind of CMD command I should run ? I would like to verify whether this will fail also outside IDE.

rat-moonshine commented 2 years ago

Check line#42 in LinkVerifier and run it on Terminal or in CMD based on your OS.

piotrzarzycki21 commented 2 years ago

What do you need in order to know what url was tested by your code ? Is it logged on console in MSDKI ?

piotrzarzycki21 commented 2 years ago

@rat-moonshine It turns out that client who reported issues with SDK Installer was using Windows 7 64bit, which probably doesn't not come with curl default. I have pass the message that we are not supporting Windows 7 anymore.

rat-moonshine commented 2 years ago

which probably doesn't not come with curl default

Well, that was a bummer if it's so!

piotrzarzycki21 commented 2 years ago

Ok but @ciacob is using Windows 10, so we may still have some problems. @ciacob Could you run on your system in console following command and pass the results here if it's possible:

curl --head --silent --fail curl https://nightlies.apache.org/Royale/Royale-asjs/apache-royale-0.9.9-SNAPSHOT-bin.zip

ciacob commented 2 years ago

OK, So doing curl with given arguments did not produce output, but didn't download either. By contrast, doing a:

c:\Users\claud> curl https://nightlies.apache.org/Royale/Royale-asjs/apache-royale-0.9.9-SNAPSHOT-bin.zip

produced this output:

curl: (35) schannel: next InitializeSecurityContext failed: Unknown error (0x80092012) - The revocation function was unable to check revocation for the certificate.

By the way, why don't you do a "classic" AS3 download instead, i.e., using FileReference?

ciacob commented 2 years ago

That might help: https://answers.microsoft.com/en-us/windows/forum/all/schannel-error-0x80092012/00b55179-11d9-4213-9e66-6667b42f11c8

rat-moonshine commented 2 years ago

curl we're using to test a link before attempting to download(using ActionScript API), the command is suppose to return output against a working link and none to broken/inaccessible:

% curl --head --silent --fail curl https://nightlies.apache.org/Royale/Royale-asjs/apache-royale-0.9.9-SNAPSHOT-bin.zip
HTTP/1.1 200 OK
Date: Mon, 18 Oct 2021 04:39:31 GMT
Server: Apache
Last-Modified: Sun, 17 Oct 2021 17:37:17 GMT
ETag: "3115b4e-5ce8fe1378f30"
Accept-Ranges: bytes
Content-Length: 51469134
Content-Type: application/zip 
rat-moonshine commented 2 years ago

Recently I started noticing this problem in our remote systems, I think we need to revisit this.

As it appeared that the current link-verification logic isn't powerful enough to determine between the broken cases. I noticed the current command also fails when a server's certificate expired:

$ curl --head --silent --fail https://moonshine-ide.com/downloads/maven/apache-maven-3.6.0-bin.tar.gz
$ [returns blank]

If we adjusted the command slightly I can see why it is failing:

$ curl --head --fail https://moonshine-ide.com/downloads/maven/apache-maven-3.6.0-bin.tar.gz
curl: (60) SSL certificate problem: certificate has expired
More details here: https://curl.haxx.se/docs/sslcerts.html

Unfortunately, I only able to produce these problems while testing in the remote system. Even if the certificate expired, the link itself working fine, so we should take that as go-ahead to download. I need to have the verification API adjust a bit to handle these cases and do a quick release.

@JoelProminic please let me know if you have any thought on the above, we can also disable the link-verification for now and do a quick release before we revisit this part, if requires.

piotrzarzycki21 commented 2 years ago

Recently I started noticing this problem in our remote systems, I think we need to revisit this.

As it appeared that the current link-verification logic isn't powerful enough to determine between the broken cases. I noticed the current command also fails when a server's certificate expired:

$ curl --head --silent --fail https://moonshine-ide.com/downloads/maven/apache-maven-3.6.0-bin.tar.gz
$ [returns blank]

If we adjusted the command slightly I can see why it is failing:

$ curl --head --fail https://moonshine-ide.com/downloads/maven/apache-maven-3.6.0-bin.tar.gz
curl: (60) SSL certificate problem: certificate has expired
More details here: https://curl.haxx.se/docs/sslcerts.html

Unfortunately, I only able to produce these problems while testing in the remote system. Even if the certificate expired, the link itself working fine, so we should take that as go-ahead to download. I need to have the verification API adjust a bit to handle these cases and do a quick release.

@JoelProminic please let me know if you have any thought on the above, we can also disable the link-verification for now and do a quick release before we revisit this part, if requires.

My client reported that she still cannot download any SDK, so please adjust that - we may decide next week to release upgrade minor version with that fix.

rat-moonshine commented 2 years ago

I shifted to AS3 alternative to verify links. @piotrzarzycki21 if you want you can ask your client to test with nightly builds for now. I shall discuss with @JoelProminic for a minor release if we want.

JoelProminic commented 2 years ago

I created a v4.1.1 milestone if we want a quick fix release for this: https://github.com/Moonshine-IDE/Moonshine-SDK-Installer/milestone/16 . We can change this to 4.2.0 if desired.

I did some tests with the new build on macOS Catalina and Windows 10, and I didn't see any a problems. I didn't confirm that I could reproduce the bug before the update, though, so it would be helpful if others could test this.

piotrzarzycki21 commented 2 years ago

I got report from client that it's working for here downloading of Apache Royale 0.9.8, 0.9.9. She have some problems with downloading Flex SDK, but all the tests has happened on Windows 7 - I explained to her that we are not supporting that system anymore.

@ciacob would you be able please try our nightly build of Moonshine SDK Installer and let us know if it's working for you - download MoonshineSDKInstaller-4.2.0.exe

ciacob commented 2 years ago

Will do it today, thank you.

On Tue, Nov 2, 2021, 12:15 Piotr Zarzycki @.***> wrote:

I got report from client that it's working for here downloading of Apache Royale 0.9.8, 0.9.9. She have some problems with downloading Flex SDK, but all the tests has happened on Windows 7 - I explained to her that we are not supporting that system anymore.

@ciacob https://github.com/ciacob would you be able please try our nightly build of Moonshine SDK Installer and let us know if it's working for you - download MoonshineSDKInstaller-4.2.0.exe https://moonshine-ide.com/downloads/msdki/dev/windows/

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Moonshine-IDE/Moonshine-SDK-Installer/issues/71#issuecomment-957300526, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABWMZ4T4UXTK7JJM2XTGJCLUJ6245ANCNFSM5FC7DP2A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

JoelProminic commented 2 years ago

We would like to get this release soon as v4.1.1.

@piotrzarzycki21 mentioned that there may be an issue with the Harman SDK install, but this is outside the scope of this issue, and we don't want to hold up the release any longer

Let's release that, because it is significant improvement for downloading Apache Royale. However I still think that we may have an issue with downloading Harman Air with Flex SDK. One of user reported me problem with downloading that sdk. Adrian was testing on his machine and initially he think that he was reproduced that issue. However after a while he discovered that unpacking Harman Air takes some time and he just need to wait. Another client reported me also that problem. I'm going to give them feedback on timing issue and see how it goes.