Update Gradle to 7.5.1 - Githubissues

Moonshine-IDE / Moonshine-SDK-Installer

To take full advantage of Moonshine IDE you will need third party SDKs like Apache® Flex or Apache® Royale. In order to make it easier for you to setup the required SDKs, we created the Moonshine SDK Installer.

https://moonshine-ide.com/download-sdk-installer/

Other

8 stars 2 forks source link

Update Gradle to 7.5.1 #99

Closed JoelProminic closed 1 year ago

JoelProminic commented 1 year ago

Gradle 7+ is required for JDK 17. We'll upgrade to the latest version, 7.5.1

rat-moonshine commented 1 year ago

Done.

JoelProminic commented 1 year ago

We'll need to test that:

The new version of the SDK can download from MSDKI even if there is an older version already
Moonshine will update to the new version of Gradle if it is using an older version.

Current Version	Show update in MSDKI	Update in SDK in Moonshine
None	Yes	Yes
Old version	Yes	Yes
Latest version	No	No

JoelProminic commented 1 year ago

I confirmed that Moonshine does not automatically update to the new Grails version. It also does not automatically update to the latest Java version (#98). Did we do this intentionally so that the user could downgrade if needed for their project? I did not find a note related to this with a quick search...

rat-moonshine commented 1 year ago

We have version-update check logic available in MSDKI, but it used selectively. As I sees the logic mainly used in case of JDK8 and Flex SDK cases.

The problem from using the test globally, for every SDK, was following reasons:

We have to parse all the SDKs' version prior a detection-test (most likely pre-running the About logic)
The returning output from About (or, software -version in a usual manner) is problematic and tricky to parse-out a value like "xx.xx.xx" so that we can compare the value with. In About section most of the SDKs do not returns a version in simple "xx.xx.xx" but with many prefix/suffix texts

In case of Gradle, it also returns a value like Gradle x.x.x - we can add separate handling specific to Gradle for this, but the solution may not best fit for other SDKs, though.

JoelProminic commented 1 year ago

The SDK update issue is a bigger topic. I'm going to move this to the JDK discussion here: https://github.com/Moonshine-IDE/Moonshine-IDE/issues/1124