search

Moonshine-IDE / Super.Human.Portal

Portal interface to show documentation for DominoVagrant and Super.Human.Installer
Other
0 stars 1 forks source link

Configure Base Nomad URL #44

Closed JoelProminic closed 7 months ago

JoelProminic commented 8 months ago

As we work towards using Super.Human.Portal as a customer/organization portal, we would like to support a central Nomad server that may not necessarily be on the same server. To support this, I should add a configuration value for the base Nomad URL.

We should watch for CORS errors for this, but I don't think it matters when opening new tabs/pages.

JoelProminic commented 7 months ago

I added support for a configured base URL for nomad: nomad_base_url

Case Behavior
Missing Use old default
Blank Use old default
Valid URL Use provided URL
Invalid URL Use provided URL - TODO: do some validation?

Testing with the Prominic URLs, I'm seeing some remaining issues with escaping nested views. I'll need to do some more investigation for this - I thought I had solved it before.

piotrzarzycki21 commented 7 months ago

I have handle default action on UI sight - it's ready for tests.

JoelProminic commented 7 months ago

The defaultAction updates are covered by #46. This issue shouldn't require any UI updates. I created a separate issue for the nested view issue with Nomad links: #49.