Moonshine-IDE / Super.Human.Portal

Portal interface to show documentation for DominoVagrant and Super.Human.Installer
Other
0 stars 1 forks source link

More Options to Control Ordering for Bookmarks #45

Closed JoelProminic closed 7 months ago

JoelProminic commented 8 months ago

For the bookmarks converted from the Prominic Portal, Justin would like to preserve the original ordering for both the categories and the bookmarks. We will probably need to define a separate "Index" property for this.

The ordering should be:

My current plan is to define the sorting on the agent side. I am already doing this for the domino-49 example. This will allow further customization, like allowing a configured view define the ordering.

I'm not sure if we want to show the index in the Royale UI It would be better to allow sorting by drag/drop or arrow buttons, and then have the server compute an appropriate index. This will probably be a separate update.

JoelProminic commented 7 months ago

I updated the CustomBookmarkRead agent to use the Bookmarks/FlatForAgent view. This can be changed using the bookmarks_view configuration value.

JoelProminic commented 7 months ago

We made some updates to support this today. I updated the Bookmarks/FlatForAgent view to sort by index first, then the category, and then the name. If no index has been specified it will be treated as 0, and displayed first in the UI.

The Royale interface was previously sorting the categories but not the bookmarks. To support the above update, @piotrzarzycki21 removed the category sorting. As a result, the category position will be based on the first appearance of the category in the bookmark list (I did a test with this to confirm this behavior). I think this behavior is reasonable. We could consider showing multiple categories with the same name in this case, but this could cause confusion when adding new bookmarks to that category.

JoelProminic commented 7 months ago

I think this issue is working as expected now, so I'm closing the issue.